{"data":{"id":"magento2-38617","source":"github-pr","sourceRef":"magento/magento2#38617","title":"Accessibility: WAI-ARIA roles nesting wrong in menu","pr":{"number":38617,"url":"https://github.com/magento/magento2/pull/38617","author":"mirianfalconi","mergedAt":"2025-08-04T06:11:48Z","mergeCommit":"b8cc640cdf8e76191657f8469b5c81909645f499","headCommit":"2bdf70ad2231aaf6aa1ba408728538a138b759f6","baseRef":"2.4-develop","diffSha256":"82cb9435f6e15d4ea82584b588145ca4cb940c22bd6db89bfa7e9f49aaa6f0f3"},"issues":[{"number":40045,"url":"https://github.com/magento/magento2/issues/40045","title":"[Issue] Accessibility: WAI-ARIA roles nesting wrong in menu","labels":["Area: Other Developer Tools","Component: Console","Issue: Confirmed","Priority: P2","Progress: done","Reproduced on 2.4.x"],"kind":"pr-derived"}],"fixedIn":"2.4.9","containingTags":["2.4.9"],"reportedOn":null,"codeMatch":{"2.4.6":"clean","2.4.6-p1":"clean","2.4.6-p2":"clean","2.4.6-p3":"clean","2.4.6-p4":"clean","2.4.6-p5":"clean","2.4.6-p6":"clean","2.4.6-p7":"clean","2.4.6-p8":"clean","2.4.6-p9":"clean","2.4.6-p10":"clean","2.4.6-p11":"clean","2.4.6-p12":"clean","2.4.6-p13":"clean","2.4.6-p14":"clean","2.4.6-p15":"clean","2.4.7":"clean","2.4.7-p1":"clean","2.4.7-p2":"clean","2.4.7-p3":"clean","2.4.7-p4":"clean","2.4.7-p5":"clean","2.4.7-p6":"clean","2.4.7-p7":"clean","2.4.7-p8":"clean","2.4.7-p9":"clean","2.4.7-p10":"clean","2.4.8":"clean","2.4.8-p1":"clean","2.4.8-p2":"clean","2.4.8-p3":"clean","2.4.8-p4":"clean","2.4.8-p5":"clean","2.4.9":"conflict"},"affectedVersions":["2.4.6","2.4.6-p1","2.4.6-p2","2.4.6-p3","2.4.6-p4","2.4.6-p5","2.4.6-p6","2.4.6-p7","2.4.6-p8","2.4.6-p9","2.4.6-p10","2.4.6-p11","2.4.6-p12","2.4.6-p13","2.4.6-p14","2.4.6-p15","2.4.7","2.4.7-p1","2.4.7-p2","2.4.7-p3","2.4.7-p4","2.4.7-p5","2.4.7-p6","2.4.7-p7","2.4.7-p8","2.4.7-p9","2.4.7-p10","2.4.8","2.4.8-p1","2.4.8-p2","2.4.8-p3","2.4.8-p4","2.4.8-p5"],"components":["magento/module-theme"],"files":[{"path":"app/code/Magento/Theme/Block/Html/Topmenu.php","change":"modified","package":"magento/module-theme"}],"stripped":{"tests":["app/code/Magento/Theme/Test/Unit/Block/Html/TopmenuTest.php","dev/tests/static/testsuite/Magento/Test/Integrity/App/Language/_files/known_invalid.xml","dev/tests/static/testsuite/Magento/Test/Integrity/App/Language/_files/known_valid.xml"],"docs":[],"outsideCode":[]},"linesChanged":28,"mergeBatched":false,"excluded":null,"sections":{"description":null,"stepsToReproduce":"1. Open the Lighthouse and do the Accessibily analysis **without** this PR \n\n![Screenshot from 2024-04-14 11-52-16](https://github.com/magento/magento2/assets/13924647/7816dffd-ce95-424c-92c3-d398ff97ad05)\n\n2. Open the Lighthouse and do the Accessibily analysis **with** this PR \n\n![Screenshot from 2024-04-14 11-56-37](https://github.com/magento/magento2/assets/13924647/7c3d368c-57d4-47ae-a953-4b680c7d1aa6)\n\n\n\n\n### Resolved issues:\n1. [x] resolves magento/magento2#40045: Accessibility: WAI-ARIA roles nesting wrong in menu","expectedResult":null,"actualResult":null,"source":"pr"},"signatures":[],"labels":{"area":["Other Developer Tools"],"component":["Console"],"priority":"P2","severity":null,"reportedOn":[]},"categories":[],"triage":{"model":"@cf/cloudflare/clef","requestHash":"471ce87a9865a5a1671d1c7b518221f21390536c9d19ce508f7ee2b119c7a3d3","isBugfix":0.9337,"changeKind":{"choice":"bugfix","probabilities":{"bugfix":0.9445,"feature":0.0103,"refactor":0.0252,"tests_only":0.0096,"docs_only":0.0049,"dependency":0.0055},"confidence":0.8714},"scope":{"score":0.896,"probabilities":{"0":0.2795,"1":0.545,"2":0.1755},"confidence":0.1089},"risk":{"score":0.55,"probabilities":{"0":0.477,"1":0.496,"2":0.027},"confidence":0.2114},"area":{"choice":"frontend","probabilities":{"catalog":0.0103,"checkout":0.0055,"customer":0.0066,"admin":0.0164,"graphql_api":0.0047,"framework":0.0189,"frontend":0.9047,"other":0.0329},"confidence":0.7947},"securityRelevant":0.0112,"reportedVersion":{"choice":"unspecified","probabilities":{"2.4.0":0.0031,"2.4.0-p1":0.0032,"2.4.1":0.0032,"2.4.1-p1":0.0034,"2.4.2":0.0042,"2.4.2-p1":0.0053,"2.4.2-p2":0.0052,"2.4.3":0.008,"2.4.3-p1":0.0107,"2.4.3-p2":0.0095,"2.4.3-p3":0.0056,"2.4.4":0.0094,"2.4.4-p1":0.0076,"2.4.4-p10":0.0057,"2.4.4-p11":0.0064,"2.4.4-p12":0.0062,"2.4.4-p13":0.0056,"2.4.4-p14":0.0077,"2.4.4-p15":0.0052,"2.4.4-p16":0.0059,"2.4.4-p17":0.0063,"2.4.4-p18":0.0047,"2.4.4-p2":0.0021,"2.4.4-p3":0.0027,"2.4.4-p4":0.0026,"2.4.4-p5":0.0035,"2.4.4-p6":0.0045,"2.4.4-p7":0.0038,"2.4.4-p8":0.0048,"2.4.4-p9":0.004,"2.4.5":0.0122,"2.4.5-p1":0.0098,"2.4.5-p10":0.0067,"2.4.5-p11":0.0129,"2.4.5-p12":0.0097,"2.4.5-p13":0.0079,"2.4.5-p14":0.0093,"2.4.5-p15":0.0074,"2.4.5-p16":0.01,"2.4.5-p17":0.0069,"2.4.5-p2":0.003,"2.4.5-p3":0.0043,"2.4.5-p4":0.005,"2.4.5-p5":0.0043,"2.4.5-p6":0.0079,"2.4.5-p7":0.0062,"2.4.5-p8":0.005,"2.4.5-p9":0.0057,"2.4.6":0.0491,"2.4.6-p1":0.0319,"2.4.6-p10":0.0137,"2.4.6-p11":0.0193,"2.4.6-p12":0.0155,"2.4.6-p13":0.012,"2.4.6-p14":0.0143,"2.4.6-p15":0.0107,"2.4.6-p2":0.0055,"2.4.6-p3":0.0085,"2.4.6-p4":0.0081,"2.4.6-p5":0.0083,"2.4.6-p6":0.0107,"2.4.6-p7":0.0093,"2.4.6-p8":0.0075,"2.4.6-p9":0.0067,"2.4.7":0.0309,"2.4.7-p1":0.0277,"2.4.7-p10":0.0132,"2.4.7-p2":0.0113,"2.4.7-p3":0.0172,"2.4.7-p4":0.0206,"2.4.7-p5":0.0144,"2.4.7-p6":0.0205,"2.4.7-p7":0.0162,"2.4.7-p8":0.0139,"2.4.7-p9":0.0094,"2.4.8":0.0254,"2.4.8-p1":0.0276,"2.4.8-p2":0.0233,"2.4.8-p3":0.0224,"2.4.8-p4":0.017,"2.4.8-p5":0.0155,"2.4.9":0.0209,"unspecified":0.1272},"confidence":0.0191},"backportWorthy":{"score":1.3609,"probabilities":{"0":0.1818,"1":0.2755,"2":0.5427},"confidence":0.1052}},"curated":{"title":"Fixes wrong WAI-ARIA role nesting in the top menu","description":"The Lighthouse Accessibility analysis has WAI-ARIA roles nesting wrong in the menu. The Topmenu block now adds role=\"menuitem\" to each menu link and role=\"presentation\" to each menu item.","categories":[],"author":"claude-code/opus-5.5","date":"2026-10-06","reviewedBy":null},"tests":{"2.4.8-p5":{"before":"fail","after":"pass","adapted":false,"runAt":"2026-10-06T09:20:07.172Z","releaseCommit":"870a22c63d9d9b68fa3297962e2d5d5841115814","suites":{"unit":{"before":"fail","after":"pass","runAt":"2026-10-06T09:20:07.172Z"}}},"2.4.7-p10":{"before":"fail","after":"pass","adapted":false,"runAt":"2026-10-06T09:29:13.708Z","releaseCommit":"72561bf80652f57cc642a03e2c9a51d74a285b14","suites":{"unit":{"before":"fail","after":"pass","runAt":"2026-10-06T09:29:13.708Z"}}}}},"_documentation":"https://magento.watch/api","_description":"Upstream fix magento2-38617 details"}