{"data":{"id":"magento2-38617","source":"github-pr","sourceRef":"magento/magento2#38617","title":"Accessibility: WAI-ARIA roles nesting wrong in menu","pr":{"number":38617,"url":"https://github.com/magento/magento2/pull/38617","author":"mirianfalconi","mergedAt":"2025-08-04T06:11:48Z","mergeCommit":"b8cc640cdf8e76191657f8469b5c81909645f499","headCommit":"2bdf70ad2231aaf6aa1ba408728538a138b759f6","baseRef":"2.4-develop","diffSha256":"82cb9435f6e15d4ea82584b588145ca4cb940c22bd6db89bfa7e9f49aaa6f0f3"},"issues":[{"number":40045,"url":"https://github.com/magento/magento2/issues/40045","title":"[Issue] Accessibility: WAI-ARIA roles nesting wrong in menu","labels":["Area: Other Developer Tools","Component: Console","Issue: Confirmed","Priority: P2","Progress: done","Reproduced on 2.4.x"],"kind":"pr-derived"}],"fixedIn":"2.4.9","containingTags":["2.4.9"],"reportedOn":null,"codeMatch":{"2.4.6":"clean","2.4.6-p1":"clean","2.4.6-p2":"clean","2.4.6-p3":"clean","2.4.6-p4":"clean","2.4.6-p5":"clean","2.4.6-p6":"clean","2.4.6-p7":"clean","2.4.6-p8":"clean","2.4.6-p9":"clean","2.4.6-p10":"clean","2.4.6-p11":"clean","2.4.6-p12":"clean","2.4.6-p13":"clean","2.4.6-p14":"clean","2.4.6-p15":"clean","2.4.7":"clean","2.4.7-p1":"clean","2.4.7-p2":"clean","2.4.7-p3":"clean","2.4.7-p4":"clean","2.4.7-p5":"clean","2.4.7-p6":"clean","2.4.7-p7":"clean","2.4.7-p8":"clean","2.4.7-p9":"clean","2.4.7-p10":"clean","2.4.8":"clean","2.4.8-p1":"clean","2.4.8-p2":"clean","2.4.8-p3":"clean","2.4.8-p4":"clean","2.4.8-p5":"clean","2.4.9":"conflict"},"affectedVersions":["2.4.6","2.4.6-p1","2.4.6-p2","2.4.6-p3","2.4.6-p4","2.4.6-p5","2.4.6-p6","2.4.6-p7","2.4.6-p8","2.4.6-p9","2.4.6-p10","2.4.6-p11","2.4.6-p12","2.4.6-p13","2.4.6-p14","2.4.6-p15","2.4.7","2.4.7-p1","2.4.7-p2","2.4.7-p3","2.4.7-p4","2.4.7-p5","2.4.7-p6","2.4.7-p7","2.4.7-p8","2.4.7-p9","2.4.7-p10","2.4.8","2.4.8-p1","2.4.8-p2","2.4.8-p3","2.4.8-p4","2.4.8-p5"],"components":["magento/module-theme"],"files":[{"path":"app/code/Magento/Theme/Block/Html/Topmenu.php","change":"modified","package":"magento/module-theme"}],"stripped":{"tests":["app/code/Magento/Theme/Test/Unit/Block/Html/TopmenuTest.php","dev/tests/static/testsuite/Magento/Test/Integrity/App/Language/_files/known_invalid.xml","dev/tests/static/testsuite/Magento/Test/Integrity/App/Language/_files/known_valid.xml"],"docs":[],"outsideCode":[]},"linesChanged":28,"mergeBatched":false,"excluded":null,"sections":{"description":null,"stepsToReproduce":"1. Open the Lighthouse and do the Accessibily analysis **without** this PR \n\n![Screenshot from 2024-04-14 11-52-16](https://github.com/magento/magento2/assets/13924647/7816dffd-ce95-424c-92c3-d398ff97ad05)\n\n2. Open the Lighthouse and do the Accessibily analysis **with** this PR \n\n![Screenshot from 2024-04-14 11-56-37](https://github.com/magento/magento2/assets/13924647/7c3d368c-57d4-47ae-a953-4b680c7d1aa6)\n\n\n\n\n### Resolved issues:\n1. [x] resolves magento/magento2#40045: Accessibility: WAI-ARIA roles nesting wrong in menu","expectedResult":null,"actualResult":null,"source":"pr"},"signatures":[],"labels":{"area":["Other Developer Tools"],"component":["Console"],"priority":"P2","severity":null,"reportedOn":[]},"categories":[],"triage":{"model":"@cf/cloudflare/clef","requestHash":"7b830abcb8be7a99d80894e02fe57025be2a69ce81181fe1cd27f3c8a69113e3","isBugfix":0.932,"changeKind":{"choice":"bugfix","probabilities":{"bugfix":0.9358,"feature":0.0089,"refactor":0.0198,"tests_only":0.0089,"docs_only":0.0046,"dependency":0.0051,"cleanup":0.0169},"confidence":0.856},"scope":{"score":0.9458,"probabilities":{"0":0.2691,"1":0.516,"2":0.2149},"confidence":0.0773},"risk":{"score":0.5863,"probabilities":{"0":0.4418,"1":0.5302,"2":0.028},"confidence":0.2156},"area":{"choice":"frontend","probabilities":{"catalog":0.0107,"checkout":0.0061,"customer":0.0071,"admin":0.0198,"graphql_api":0.0051,"framework":0.019,"frontend":0.9014,"other":0.0308},"confidence":0.788},"securityRelevant":0.0094,"reportedVersion":{"choice":"unspecified","probabilities":{"2.4.0":0.0029,"2.4.0-p1":0.0031,"2.4.1":0.0032,"2.4.1-p1":0.0034,"2.4.2":0.0044,"2.4.2-p1":0.0043,"2.4.2-p2":0.0045,"2.4.3":0.0074,"2.4.3-p1":0.0096,"2.4.3-p2":0.0079,"2.4.3-p3":0.0052,"2.4.4":0.0088,"2.4.4-p1":0.0072,"2.4.4-p10":0.0058,"2.4.4-p11":0.0066,"2.4.4-p12":0.0059,"2.4.4-p13":0.0055,"2.4.4-p14":0.0086,"2.4.4-p15":0.0051,"2.4.4-p16":0.0062,"2.4.4-p17":0.0062,"2.4.4-p18":0.0047,"2.4.4-p2":0.0021,"2.4.4-p3":0.0025,"2.4.4-p4":0.0024,"2.4.4-p5":0.0033,"2.4.4-p6":0.0042,"2.4.4-p7":0.0036,"2.4.4-p8":0.0045,"2.4.4-p9":0.0037,"2.4.5":0.0116,"2.4.5-p1":0.0093,"2.4.5-p10":0.0064,"2.4.5-p11":0.0126,"2.4.5-p12":0.0092,"2.4.5-p13":0.0077,"2.4.5-p14":0.009,"2.4.5-p15":0.0072,"2.4.5-p16":0.0098,"2.4.5-p17":0.0069,"2.4.5-p2":0.003,"2.4.5-p3":0.0043,"2.4.5-p4":0.0054,"2.4.5-p5":0.0046,"2.4.5-p6":0.0077,"2.4.5-p7":0.0064,"2.4.5-p8":0.0051,"2.4.5-p9":0.0056,"2.4.6":0.049,"2.4.6-p1":0.0349,"2.4.6-p10":0.0154,"2.4.6-p11":0.0199,"2.4.6-p12":0.0149,"2.4.6-p13":0.0131,"2.4.6-p14":0.0154,"2.4.6-p15":0.0112,"2.4.6-p2":0.0057,"2.4.6-p3":0.0091,"2.4.6-p4":0.0099,"2.4.6-p5":0.0081,"2.4.6-p6":0.0116,"2.4.6-p7":0.0115,"2.4.6-p8":0.0078,"2.4.6-p9":0.0066,"2.4.7":0.0287,"2.4.7-p1":0.0305,"2.4.7-p10":0.0118,"2.4.7-p2":0.0112,"2.4.7-p3":0.0171,"2.4.7-p4":0.0201,"2.4.7-p5":0.0167,"2.4.7-p6":0.02,"2.4.7-p7":0.018,"2.4.7-p8":0.0142,"2.4.7-p9":0.0087,"2.4.8":0.0247,"2.4.8-p1":0.0273,"2.4.8-p2":0.0252,"2.4.8-p3":0.0239,"2.4.8-p4":0.0176,"2.4.8-p5":0.0156,"2.4.9":0.0209,"unspecified":0.1191},"confidence":0.0175},"backportWorthy":{"score":1.3716,"probabilities":{"0":0.181,"1":0.2665,"2":0.5525},"confidence":0.1136}},"curated":{"title":"Fixes wrong WAI-ARIA role nesting in the top menu","description":"The Lighthouse Accessibility analysis has WAI-ARIA roles nesting wrong in the menu. The Topmenu block now adds role=\"menuitem\" to each menu link and role=\"presentation\" to each menu item.","categories":[],"author":"claude-code/opus-5.5","date":"2026-10-06","reviewedBy":null},"tests":{"2.4.8-p5":{"before":"fail","after":"pass","adapted":false,"runAt":"2026-10-06T09:20:07.172Z","releaseCommit":"870a22c63d9d9b68fa3297962e2d5d5841115814","suites":{"unit":{"before":"fail","after":"pass","runAt":"2026-10-06T09:20:07.172Z"}}},"2.4.7-p10":{"before":"fail","after":"pass","adapted":false,"runAt":"2026-10-06T09:29:13.708Z","releaseCommit":"72561bf80652f57cc642a03e2c9a51d74a285b14","suites":{"unit":{"before":"fail","after":"pass","runAt":"2026-10-06T09:29:13.708Z"}}}}},"_documentation":"https://magento.watch/api","_description":"Upstream fix magento2-38617 details"}