{"data":{"id":"magento2-39099","source":"github-pr","sourceRef":"magento/magento2#39099","title":"Remove all marketing get parameters to minimize the cache using built-in FPC","pr":{"number":39099,"url":"https://github.com/magento/magento2/pull/39099","author":"rogerdz","mergedAt":"2024-12-21T01:10:09Z","mergeCommit":"8f36bc3751ce4737156c88800384ea1a91e07c4d","headCommit":"ebcc80635c977a15c96ca99b731334f608dd7ef3","baseRef":"2.4-develop","diffSha256":"125ac0cb8bae4b8d388916e36011c4047c717d565b76975f6895923ac5554f46"},"issues":[{"number":39266,"url":"https://github.com/magento/magento2/issues/39266","title":"[Issue] Remove all marketing get parameters to minimize the cache","labels":["Area: Framework","Component: Framework/Cache","Issue: Confirmed","Priority: P2","Progress: done","Reported on 2.4.x","Reproduced on 2.4.x"],"kind":"pr-derived"}],"fixedIn":"2.4.8","containingTags":["2.4.8","2.4.8-p1","2.4.8-p2","2.4.8-p3","2.4.8-p4","2.4.8-p5","2.4.9"],"reportedOn":null,"codeMatch":{"2.4.6":"file-missing","2.4.6-p1":"file-missing","2.4.6-p2":"file-missing","2.4.6-p3":"file-missing","2.4.6-p4":"file-missing","2.4.6-p5":"file-missing","2.4.6-p6":"file-missing","2.4.6-p7":"file-missing","2.4.6-p8":"file-missing","2.4.6-p9":"file-missing","2.4.6-p10":"file-missing","2.4.6-p11":"file-missing","2.4.6-p12":"file-missing","2.4.6-p13":"file-missing","2.4.6-p14":"file-missing","2.4.6-p15":"file-missing","2.4.7":"conflict","2.4.7-p1":"conflict","2.4.7-p2":"conflict","2.4.7-p3":"conflict","2.4.7-p4":"conflict","2.4.7-p5":"conflict","2.4.7-p6":"conflict","2.4.7-p7":"conflict","2.4.7-p8":"conflict","2.4.7-p9":"conflict","2.4.7-p10":"conflict","2.4.8":"conflict","2.4.8-p1":"conflict","2.4.8-p2":"conflict","2.4.8-p3":"conflict","2.4.8-p4":"conflict","2.4.8-p5":"conflict","2.4.9":"conflict"},"affectedVersions":[],"components":["magento/framework","magento/module-page-cache"],"files":[{"path":"app/code/Magento/PageCache/Model/App/Request/Http/IdentifierForSave.php","change":"modified","package":"magento/module-page-cache"},{"path":"lib/internal/Magento/Framework/App/PageCache/Identifier.php","change":"modified","package":"magento/framework"}],"stripped":{"tests":["app/code/Magento/PageCache/Test/Unit/Model/App/Request/Http/IdentifierForSaveTest.php","lib/internal/Magento/Framework/App/Test/Unit/PageCache/IdentifierTest.php"],"docs":[],"outsideCode":[]},"linesChanged":55,"mergeBatched":false,"excluded":null,"sections":{"description":"Same logic when use varnish (https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/PageCache/etc/varnish7.vcl#L84) but for build-in fpc","stepsToReproduce":"1. Clear cache: bin/magento cache:clean\n2. Run command: curl -I --location-trusted 'https://magento2.test/gear/bags.html?test=111&utm_source=123&gclid=abc' | grep -i X-Magento-Cache-Debug, it return x-magento-cache-debug: MISS => correct\n3. Run command: curl -I --location-trusted 'https://magento2.test/gear/bags.html?test=111&utm_source=123&gclid=abc' | grep -i X-Magento-Cache-Debug, it return x-magento-cache-debug: HIT => correct\n4. Run command: curl -I --location-trusted 'https://magento2.test/gear/bags.html?test=111' | grep -i X-Magento-Cache-Debug => it should return x-magento-cache-debug: HIT","expectedResult":null,"actualResult":null,"source":"pr"},"signatures":[],"labels":{"area":["Framework"],"component":["Framework/Cache"],"priority":"P2","severity":null,"reportedOn":["2.4.x"]},"categories":["Cache"],"triage":{"model":"@cf/cloudflare/clef","requestHash":"52a47652c21cde62b6dc868933d14d0ee18ed7fde3a04876879f3700d5260c01","isBugfix":0.3816,"changeKind":{"choice":"bugfix","probabilities":{"bugfix":0.5617,"feature":0.264,"refactor":0.0714,"tests_only":0.0104,"docs_only":0.0036,"dependency":0.0047,"cleanup":0.0842},"confidence":0.2971},"scope":{"score":0.9306,"probabilities":{"0":0.3413,"1":0.3869,"2":0.2718},"confidence":0.0101},"risk":{"score":0.6772,"probabilities":{"0":0.3786,"1":0.5656,"2":0.0558},"confidence":0.1996},"area":{"choice":"framework","probabilities":{"catalog":0.0066,"checkout":0.0043,"customer":0.0033,"admin":0.0037,"graphql_api":0.0023,"framework":0.9607,"frontend":0.0104,"other":0.0087},"confidence":0.9122},"securityRelevant":0.0086,"reportedVersion":{"choice":"unspecified","probabilities":{"2.4.0":0.0043,"2.4.0-p1":0.0039,"2.4.1":0.005,"2.4.1-p1":0.0047,"2.4.2":0.0078,"2.4.2-p1":0.0076,"2.4.2-p2":0.0101,"2.4.3":0.0113,"2.4.3-p1":0.0139,"2.4.3-p2":0.0158,"2.4.3-p3":0.0092,"2.4.4":0.0161,"2.4.4-p1":0.0106,"2.4.4-p10":0.0074,"2.4.4-p11":0.0084,"2.4.4-p12":0.0075,"2.4.4-p13":0.0074,"2.4.4-p14":0.0103,"2.4.4-p15":0.0071,"2.4.4-p16":0.0078,"2.4.4-p17":0.0067,"2.4.4-p18":0.0065,"2.4.4-p2":0.0027,"2.4.4-p3":0.0037,"2.4.4-p4":0.0037,"2.4.4-p5":0.0054,"2.4.4-p6":0.0051,"2.4.4-p7":0.0047,"2.4.4-p8":0.0046,"2.4.4-p9":0.0049,"2.4.5":0.0133,"2.4.5-p1":0.0122,"2.4.5-p10":0.0083,"2.4.5-p11":0.0134,"2.4.5-p12":0.0115,"2.4.5-p13":0.0091,"2.4.5-p14":0.0094,"2.4.5-p15":0.0072,"2.4.5-p16":0.0085,"2.4.5-p17":0.0077,"2.4.5-p2":0.0043,"2.4.5-p3":0.0058,"2.4.5-p4":0.0073,"2.4.5-p5":0.0061,"2.4.5-p6":0.0054,"2.4.5-p7":0.0066,"2.4.5-p8":0.0062,"2.4.5-p9":0.0049,"2.4.6":0.027,"2.4.6-p1":0.0208,"2.4.6-p10":0.0092,"2.4.6-p11":0.013,"2.4.6-p12":0.0134,"2.4.6-p13":0.0111,"2.4.6-p14":0.0133,"2.4.6-p15":0.0089,"2.4.6-p2":0.0051,"2.4.6-p3":0.0083,"2.4.6-p4":0.0087,"2.4.6-p5":0.0077,"2.4.6-p6":0.0086,"2.4.6-p7":0.0095,"2.4.6-p8":0.0069,"2.4.6-p9":0.0056,"2.4.7":0.0174,"2.4.7-p1":0.0184,"2.4.7-p10":0.0104,"2.4.7-p2":0.0096,"2.4.7-p3":0.0167,"2.4.7-p4":0.0186,"2.4.7-p5":0.0154,"2.4.7-p6":0.021,"2.4.7-p7":0.0163,"2.4.7-p8":0.016,"2.4.7-p9":0.0079,"2.4.8":0.021,"2.4.8-p1":0.0174,"2.4.8-p2":0.0202,"2.4.8-p3":0.0202,"2.4.8-p4":0.018,"2.4.8-p5":0.0176,"2.4.9":0.0196,"unspecified":0.1498},"confidence":0.0218},"backportWorthy":{"score":1.3474,"probabilities":{"0":0.1622,"1":0.3282,"2":0.5096},"confidence":0.0906}},"curated":{"title":"Fixes the issue where the built-in FPC keeps marketing GET parameters","description":"The built-in FPC does not remove marketing GET parameters such as utm_source and gclid to minimize the cache, as Varnish does. The framework PageCache Identifier gets a list of marketing parameters to detect by pattern, and Identifier and IdentifierForSave now preg_replace them out of the request URI string for the page cache identifier.","categories":["Cache"],"author":"claude-code/opus-5.5","date":"2026-10-06","reviewedBy":null},"tests":null},"_documentation":"https://magento.watch/api","_description":"Upstream fix magento2-39099 details"}