{"data":{"id":"magento2-39164","source":"github-pr","sourceRef":"magento/magento2#39164","title":"Accessibility: WAI-ARIA roles nesting wrong in menu","pr":{"number":39164,"url":"https://github.com/magento/magento2/pull/39164","author":"Serfe-com","mergedAt":"2025-04-16T11:05:48Z","mergeCommit":"0df0711d6470f4f887a039ea6d821a74de826af6","headCommit":"1d66940e34d99d90547deaa636fdaa05bbfeb0c1","baseRef":"2.4-develop","diffSha256":"0d5e5bd85c80b017cc33ce4eca730eb73f71803532b9c4af2bde73e95373fc09"},"issues":[{"number":35889,"url":"https://github.com/magento/magento2/issues/35889","title":"Accessibility: WAI-ARIA roles nesting wrong in menu","labels":["Area: Other Developer Tools","Component: Developer","Issue: Confirmed","Priority: P2","Progress: PR in progress","Reproduced on 2.4.x"],"kind":"human"},{"number":39054,"url":"https://github.com/magento/magento2/issues/39054","title":"Lighthouse Accessibility failure","labels":["Area: Other Developer Tools","Component: Developer","Issue: Confirmed","Priority: P2","Progress: PR in progress","Progress: done","Reported on 2.4.7-p1","Reproduced on 2.4.x"],"kind":"human"}],"fixedIn":"2.4.9","containingTags":["2.4.9"],"reportedOn":"2.4.7-p1","codeMatch":{"2.4.6":"clean","2.4.6-p1":"clean","2.4.6-p2":"clean","2.4.6-p3":"clean","2.4.6-p4":"clean","2.4.6-p5":"clean","2.4.6-p6":"clean","2.4.6-p7":"clean","2.4.6-p8":"clean","2.4.6-p9":"clean","2.4.6-p10":"clean","2.4.6-p11":"clean","2.4.6-p12":"clean","2.4.6-p13":"clean","2.4.6-p14":"clean","2.4.6-p15":"clean","2.4.7":"clean","2.4.7-p1":"clean","2.4.7-p2":"clean","2.4.7-p3":"clean","2.4.7-p4":"clean","2.4.7-p5":"clean","2.4.7-p6":"clean","2.4.7-p7":"clean","2.4.7-p8":"clean","2.4.7-p9":"clean","2.4.7-p10":"clean","2.4.8":"clean","2.4.8-p1":"clean","2.4.8-p2":"clean","2.4.8-p3":"clean","2.4.8-p4":"clean","2.4.8-p5":"clean","2.4.9":"conflict"},"affectedVersions":["2.4.6","2.4.6-p1","2.4.6-p2","2.4.6-p3","2.4.6-p4","2.4.6-p5","2.4.6-p6","2.4.6-p7","2.4.6-p8","2.4.6-p9","2.4.6-p10","2.4.6-p11","2.4.6-p12","2.4.6-p13","2.4.6-p14","2.4.6-p15","2.4.7","2.4.7-p1","2.4.7-p2","2.4.7-p3","2.4.7-p4","2.4.7-p5","2.4.7-p6","2.4.7-p7","2.4.7-p8","2.4.7-p9","2.4.7-p10","2.4.8","2.4.8-p1","2.4.8-p2","2.4.8-p3","2.4.8-p4","2.4.8-p5"],"components":["magento/magento2-base","magento/module-theme"],"files":[{"path":"app/code/Magento/Theme/view/frontend/templates/html/sections.phtml","change":"modified","package":"magento/module-theme"},{"path":"app/design/frontend/Magento/blank/Magento_Swatches/web/css/source/_module.less","change":"modified","package":"magento/magento2-base"}],"stripped":{"tests":[],"docs":[],"outsideCode":[]},"linesChanged":31,"mergeBatched":false,"excluded":null,"sections":{"description":"```\n<ul role=\"menu\">\n <li>\n  <a href=\"\" role=\"menuitem\">link</a>\n </li>\n</ul>\n```","stepsToReproduce":"Navigate to storeview\nanalyze html code of menu for correct ARIA markup","expectedResult":"Menu should be structured according to ARIA schema the following way:\n```\n<ul role=\"menu\">\n <li role=\"none\">\n  <a href=\"\" role=\"menuitem\">link</a>\n </li>\n</ul>\n```","actualResult":"```\n<ul role=\"menu\">\n <li>\n  <a href=\"\" role=\"menuitem\">link</a>\n </li>\n</ul>\n```\n\nAs the `li` tag has no role, the child element for the menu role is missing and the parent element for the menuitem role is missing. \n\nUsers who rely on accessibility tools might run into a deadend here.","source":"issue"},"signatures":[],"labels":{"area":["Other Developer Tools"],"component":["Developer"],"priority":"P2","severity":null,"reportedOn":["2.4.7-p1"]},"categories":[],"triage":{"model":"@cf/cloudflare/clef","requestHash":"899d465372072ae29f579f85078cc2b05c5678338812c3706d81b19c37be49d9","isBugfix":0.9074,"changeKind":{"choice":"bugfix","probabilities":{"bugfix":0.9459,"feature":0.0123,"refactor":0.0235,"tests_only":0.0059,"docs_only":0.0056,"dependency":0.0068},"confidence":0.8746},"scope":{"score":0.951,"probabilities":{"0":0.2712,"1":0.5067,"2":0.2221},"confidence":0.0694},"risk":{"score":0.6438,"probabilities":{"0":0.3793,"1":0.5976,"2":0.0231},"confidence":0.2523},"area":{"choice":"frontend","probabilities":{"catalog":0.0082,"checkout":0.0041,"customer":0.004,"admin":0.008,"graphql_api":0.0033,"framework":0.0096,"frontend":0.9498,"other":0.013},"confidence":0.8885},"securityRelevant":0.0098,"reportedVersion":{"choice":"2.4.7-p1","probabilities":{"2.4.0":0.002,"2.4.0-p1":0.0024,"2.4.1":0.0021,"2.4.1-p1":0.0024,"2.4.2":0.0024,"2.4.2-p1":0.0028,"2.4.2-p2":0.003,"2.4.3":0.003,"2.4.3-p1":0.0036,"2.4.3-p2":0.0041,"2.4.3-p3":0.0029,"2.4.4":0.0936,"2.4.4-p1":0.0066,"2.4.4-p10":0.0056,"2.4.4-p11":0.0069,"2.4.4-p12":0.0044,"2.4.4-p13":0.0041,"2.4.4-p14":0.0054,"2.4.4-p15":0.0044,"2.4.4-p16":0.0052,"2.4.4-p17":0.0048,"2.4.4-p18":0.0042,"2.4.4-p2":0.003,"2.4.4-p3":0.0027,"2.4.4-p4":0.0026,"2.4.4-p5":0.003,"2.4.4-p6":0.003,"2.4.4-p7":0.0034,"2.4.4-p8":0.0033,"2.4.4-p9":0.0027,"2.4.5":0.0026,"2.4.5-p1":0.0028,"2.4.5-p10":0.0025,"2.4.5-p11":0.0031,"2.4.5-p12":0.0039,"2.4.5-p13":0.0038,"2.4.5-p14":0.0041,"2.4.5-p15":0.0033,"2.4.5-p16":0.0042,"2.4.5-p17":0.004,"2.4.5-p2":0.0024,"2.4.5-p3":0.0026,"2.4.5-p4":0.0026,"2.4.5-p5":0.0027,"2.4.5-p6":0.0031,"2.4.5-p7":0.0035,"2.4.5-p8":0.0033,"2.4.5-p9":0.0024,"2.4.6":0.0038,"2.4.6-p1":0.0045,"2.4.6-p10":0.005,"2.4.6-p11":0.0057,"2.4.6-p12":0.0074,"2.4.6-p13":0.0064,"2.4.6-p14":0.0053,"2.4.6-p15":0.0045,"2.4.6-p2":0.0028,"2.4.6-p3":0.0043,"2.4.6-p4":0.0053,"2.4.6-p5":0.0046,"2.4.6-p6":0.0048,"2.4.6-p7":0.0062,"2.4.6-p8":0.0034,"2.4.6-p9":0.0028,"2.4.7":0.048,"2.4.7-p1":0.4378,"2.4.7-p10":0.0085,"2.4.7-p2":0.0219,"2.4.7-p3":0.0169,"2.4.7-p4":0.0136,"2.4.7-p5":0.0132,"2.4.7-p6":0.0134,"2.4.7-p7":0.0147,"2.4.7-p8":0.0097,"2.4.7-p9":0.0063,"2.4.8":0.0039,"2.4.8-p1":0.0059,"2.4.8-p2":0.0077,"2.4.8-p3":0.0089,"2.4.8-p4":0.0078,"2.4.8-p5":0.0082,"2.4.9":0.0055,"unspecified":0.0148},"confidence":0.1963},"backportWorthy":{"score":1.2581,"probabilities":{"0":0.2213,"1":0.2994,"2":0.4793},"confidence":0.0525}},"curated":null,"tests":null},"_documentation":"https://magento.watch/api","_description":"Upstream fix magento2-39164 details"}