QUALITY PATCH

ACSD-67659: The translated exception message is used to map the error code for GraphQL requests…

The translated exception message is used to map the error code for GraphQL requests, causing known errors to return an UNDEFINED error code instead of the correct one. Quality patch ACSD-67659 for magento/module-async-order-graph-ql applies to Magento Open Source and Adobe Commerce 2.4.8 to 2.4.8-p2.

Categories
GraphQL
Components
magento/module-async-order-graph-ql, magento/framework, magento/module-graph-ql, magento/module-quote-graph-ql
Origin
adobe-commerce-support
Since QPT
1.1.70

Issue

The translated exception message is used to map the error code for GraphQL requests, causing known errors to return an UNDEFINED error code instead of the correct one.

Steps to reproduce

1. Add file app/i18n/Magento/de_DE/de_DE.csv with a translation for the error string, such as: "Could not find a cart with ID ""%masked_cart_id""","we have an UNDEFINED issue",module,Magento_QuoteGraphQl 2. In the Admin panel, go to Stores > Settings > All Stores > Create Store View to create a store view. 3. Set Code to test. 4. Assign german language to the newly created store view. 5. Run the commands setup:upgrade and setup:static-content:deploy -f. 6. Run the following GraphQL query with header Store:test: mutation { placeOrder(input: { cart_id: "test" }) { orderV2 { id number } } }

Adobe's page lists 2.4.8 - 2.4.8-p2 as compatible; the versions below are resolved from the current QPT constraints and are the ones the tool will offer.

Adobe scheduled the permanent fix for 2.4.9.

Install

Install the Quality Patches Tool with composer require magento/quality-patches, apply the prerequisites listed for all files applicable to your distribution and version first, then run vendor/bin/magento-patches apply ACSD-67659. On Cloud, add ACSD-67659 under stage.build.QUALITY_PATCHES in .magento.env.yaml.

For cweagans/composer-patches, choose a compatible version below and download the bundle. Copy its ACSD-67659/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Bundle prerequisites the same way and list them first. Paths are relative to each package root, using the default -p1 level. Prefer local files when configuring composer-patches; a remote URL can change.

Patch files and compatible versions

Packages across compatible versions (3): magento/module-graph-ql, magento/module-quote-graph-ql, magento/framework
Packages across compatible versions (4): magento/module-async-order-graph-ql, magento/module-graph-ql, magento/module-quote-graph-ql, magento/framework

magento/magento2-ee-base >=2.4.8 <2.4.8-p3

Magento Open Source
—
Adobe Commerce
2.4.8-p2, 2.4.8-p1, 2.4.8
Patch file
patches/commerce/ACSD-67659_2.4.8-p2.patch
  • vendor/magento/module-async-order-graph-ql/Model/Cart/PlaceOrderAsync.php

magento/magento2-base >=2.4.8 <2.4.8-p3

Magento Open Source
2.4.8-p2, 2.4.8-p1, 2.4.8
Adobe Commerce
2.4.8-p2, 2.4.8-p1, 2.4.8
Patch file
patches/os/ACSD-67659_2.4.8-p2.patch
  • vendor/magento/module-graph-ql/Helper/Error/AggregateExceptionMessageFormatter.php
  • vendor/magento/module-quote-graph-ql/Model/Cart/GetCartForCheckout.php
  • vendor/magento/module-quote-graph-ql/Model/Cart/GetCartForUser.php
  • vendor/magento/module-quote-graph-ql/Model/ErrorMapper.php (added)
  • vendor/magento/module-quote-graph-ql/Model/OrderErrorProcessor.php (added)
  • vendor/magento/module-quote-graph-ql/Model/OrderResponseFormatter.php (added)
  • vendor/magento/module-quote-graph-ql/Model/QuoteException.php (added)
  • vendor/magento/module-quote-graph-ql/Model/Resolver/EstimateShippingMethods.php
  • vendor/magento/module-quote-graph-ql/Model/Resolver/EstimateTotals.php
  • vendor/magento/module-quote-graph-ql/Model/Resolver/PlaceOrder.php
  • vendor/magento/module-quote-graph-ql/Model/Resolver/RemoveItemFromCart.php
  • vendor/magento/module-quote-graph-ql/etc/graphql/di.xml
  • vendor/magento/module-quote-graph-ql/etc/schema.graphqls
  • vendor/magento/framework/GraphQl/Query/QueryDataFormatter.php (added)
  • vendor/magento/framework/GraphQl/Query/QueryProcessor.php
  • vendor/magento/framework/GraphQl/Query/QueryResponseFormatterInterface.php (added)

Sources

Łukasz Bajsarowicz
Built by

Łukasz Bajsarowicz, e-commerce architect

Magento and Adobe Commerce architecture, upgrades, performance and audits for merchants and agencies since 2015; magento.watch is the tooling I use on those projects.

Open source, maintained on weekends.