magento2-30479: Sales rule conditions sometimes hit undefined method isAllowedForRuleCondition
Community fix magento2-30479 merged into magento/magento2 on 2025-08-19, released in 2.4.9; applies cleanly to 6 releases from 2.4.8 to 2.4.8-p5.
Sales rule conditions sometimes hit undefined method isAllowedForRuleCondition edited
- Pull request title
- fix undefined method isAllowedForRuleCondition
- Pull request
- magento/magento2#30479
- Issues
- —
- Author
- @yaroslav-zenin
- Merged
- 2025-08-19
- Fixed in
- 2.4.9
- Reported on
- —
- Categories
- —
- Components
- magento/module-sales-rule
Labels
- Area
- —
- Component
- —
- Priority
- —
- Severity
- —
- Reported on (labels)
- —
Issue
Title and steps come from the upstream issue and pull request.
Description
\Magento\SalesRule\Model\Rule\Condition\Product::loadAttributeOptions we got \Magento\Catalog\Model\ResourceModel\Eav\Attribute model instead of \Magento\Catalog\Model\ResourceModel\Eav\Attribute. This is not a permanent issue just happen sometimes and very difficult to reproduce. This pull request just change condition order but this is enough to check if method present in resource model, so regular model will be skipped.
Taken from the upstream pull request.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 conflict 2.4.6-p1 conflict 2.4.6-p2 conflict 2.4.6-p3 conflict 2.4.6-p4 conflict 2.4.6-p5 conflict 2.4.6-p6 conflict 2.4.6-p7 conflict 2.4.6-p8 conflict 2.4.6-p9 conflict 2.4.6-p10 conflict 2.4.6-p11 conflict 2.4.6-p12 conflict 2.4.6-p13 conflict 2.4.6-p14 conflict 2.4.6-p15 conflict | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 conflict 2.4.7-p1 conflict 2.4.7-p2 conflict 2.4.7-p3 conflict 2.4.7-p4 conflict 2.4.7-p5 conflict 2.4.7-p6 conflict 2.4.7-p7 conflict 2.4.7-p8 conflict 2.4.7-p9 conflict 2.4.7-p10 conflict | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 clean 2.4.8-p1 clean 2.4.8-p2 clean 2.4.8-p3 clean 2.4.8-p4 clean 2.4.8-p5 clean | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: fails before, passes afterunit: fails before, passes after |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 90.9%. Probability it is security relevant: 0.8%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 80.4%, refactor 12.6%, cleanup 3.3%, tests_only 1.9%, feature 0.8%, docs_only 0.6%, dependency 0.5% | 60.8% |
| Area | catalog | catalog 38.9%, checkout 26.0%, other 13.6% | 15.1% |
| Reported version | unspecified | unspecified 21.9%, 2.4.6 2.9%, 2.4.4 2.1% | 4.5% |
| Scope | 0.72 of 2 | 1 47.3%, 0 40.6%, 2 12.2% | 10.4% |
| Risk | 0.55 of 2 | 0 65.0%, 2 20.5%, 1 14.4% | 22.9% |
| Worth backporting | 1.36 of 2 | 2 50.1%, 1 35.8%, 0 14.1% | 9.8% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-30479/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-30479 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/30479 Author: @yaroslav-zenin Source commit: 5cd6c95cb3bc50d4e28afb4909971a7bf792ed72 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
