magento2-31231: Inconsistent Parent Only and Children Only labels in cart price rules
Community fix magento2-31231 merged into magento/magento2 on 2025-03-05, released in 2.4.8; applies cleanly to 14 releases from 2.4.6-p9 to 2.4.7-p10.
Fixes inconsistent Parent Only and Children Only labels in cart price rules edited
- Pull request title
- Inconsistent labels for attributes in marketing rules
- Pull request
- magento/magento2#31231
- Issues
- #31232 pr-derived
- Author
- @DmitryFurs
- Merged
- 2025-03-05
- Fixed in
- 2.4.8
- Reported on
- —
- Categories
- Admin
- Components
- magento/module-sales-rule
Labels
- Area
- Admin UI
- Component
- SalesRule
- Priority
- P4
- Severity
- S4
- Reported on (labels)
- 2.4.x
Issue
Title and steps come from the upstream issue and pull request.
Description
Steps to reproduce
2. Add Product attribute combination section
3. Сheck the category and attribute options
Taken from the upstream pull request.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 conflict 2.4.6-p1 conflict 2.4.6-p2 conflict 2.4.6-p3 conflict 2.4.6-p4 conflict 2.4.6-p5 conflict 2.4.6-p6 conflict 2.4.6-p7 conflict 2.4.6-p8 conflict 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 conflict 2.4.7-p1 conflict 2.4.7-p2 conflict 2.4.7-p3 conflict 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 88.9%. Probability it is security relevant: 0.5%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 92.4%, refactor 4.9%, docs_only 1.0%, feature 0.8%, tests_only 0.5%, dependency 0.4% | 82.8% |
| Area | admin | admin 78.4%, catalog 8.2%, other 5.1% | 57.2% |
| Reported version | unspecified | unspecified 20.3%, 2.4.3 3.9%, 2.4.4 3.9% | 4.3% |
| Scope | 0.53 of 2 | 0 50.7%, 1 45.5%, 2 3.8% | 19.8% |
| Risk | 0.19 of 2 | 0 86.0%, 1 9.2%, 2 4.8% | 62.7% |
| Worth backporting | 0.59 of 2 | 0 57.5%, 1 25.5%, 2 17.0% | 13.7% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-31231/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-31231 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/31231 Issue: https://github.com/magento/magento2/issues/31232 Author: @DmitryFurs Source commit: afa0d8a6e5e76de0ca12fc6d77b2f5bf096729a5 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
