magento2-32511: Failed payment email showing shipping details for virtual orders
Community fix magento2-32511 merged into magento/magento2 on 2024-07-04, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
Fixes the failed payment email showing shipping details for virtual orders edited
- Pull request title
- [Checkout] Depend directives updated in failed payment email template
- Pull request
- magento/magento2#32511
- Issues
- #32781 pr-derived
- Author
- @srsathish92
- Merged
- 2024-07-04
- Fixed in
- 2.4.8
- Reported on
- —
- Categories
- Order/Checkout
- Components
- magento/module-checkout
Labels
- Area
- Cart & Checkout
- Component
- Checkout
- Priority
- P2
- Severity
- S3
- Reported on (labels)
- —
Issue
Title and steps come from the upstream issue and pull request.
Description
Steps to reproduce
2. Add trigger failed payment email logic in exception on any payment
3. Placed Order with wrong details
4. Receive failed payment email without shipping address & shipping method
Taken from the upstream pull request.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 73.9%. Probability it is security relevant: 0.8%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 84.6%, refactor 9.8%, feature 2.4%, dependency 1.5%, docs_only 1.1%, tests_only 0.6% | 67.1% |
| Area | checkout | checkout 89.7%, frontend 4.7%, admin 2.8% | 78.1% |
| Reported version | unspecified | unspecified 27.5%, 2.4.6 2.7%, 2.4.8 2.0% | 7.3% |
| Scope | 0.60 of 2 | 1 49.3%, 0 45.3%, 2 5.4% | 17.7% |
| Risk | 0.57 of 2 | 0 54.1%, 1 34.9%, 2 10.9% | 14.0% |
| Worth backporting | 1.20 of 2 | 2 44.9%, 1 30.0%, 0 25.1% | 3.2% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-32511/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-32511 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/32511 Issue: https://github.com/magento/magento2/issues/32781 Author: @srsathish92 Source commit: f0cfdbd24b7fa65dad3ee35554f7ad59560843d7 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
