UPSTREAM FIX

magento2-33414: Renames misspelled currier JS handler functions in the order tracking template

Community fix magento2-33414 merged into magento/magento2 on 2024-09-05, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.

Renames misspelled currier JS handler functions in the order tracking template edited

Pull request title
Fixed typo in tracking.phtml - renamed JS-functions "currier" to "carrier"
Pull request
magento/magento2#33414
Issues
#34523 pr-derived
Author
@4ctobias
Merged
2024-09-05
Fixed in
2.4.8
Reported on
—
Categories
Shipping
Components
magento/module-shipping

Labels

Area
Shipping
Component
Shipping
Priority
P4
Severity
S4
Reported on (labels)
—

Issue

Title and steps come from the upstream issue and pull request.

Description

While implementing a custom shipping carrier I mentioned some typos in the JS-handler-functions used in the Magento_Shipping/view/adminhtml/templates/order/tracking.phtml:

Taken from the upstream pull request.

Code match per tag

Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.

LineCode match per tagTests
2.4.6
2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean
2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data
2.4.7
2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean
2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data
2.4.8
2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix
2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data
2.4.9
2.4.9 conflictcontains the fix
2.4.9: no test data

Triage

Model @cf/cloudflare/clef. Probability this is a bug fix: 56.0%. Probability it is security relevant: 0.7%.

Show the model's answers and probabilities
QuestionAnswerProbabilitiesConfidence
Change kindbugfixbugfix 61.2%, refactor 34.3%, docs_only 2.5%, feature 0.8%, tests_only 0.7%, dependency 0.5%39.1%
Areaadminadmin 49.0%, checkout 27.6%, frontend 17.4%25.4%
Reported versionunspecifiedunspecified 25.7%, 2.4.6 2.1%, 2.4.9 1.7%6.3%
Scope0.72 of 21 53.8%, 0 37.0%, 2 9.2%15.3%
Risk0.53 of 20 49.1%, 1 48.8%, 2 2.2%21.9%
Worth backporting0.72 of 20 49.2%, 1 29.4%, 2 21.3%6.2%

Download

For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-33414/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.

Packages (1): magento/module-shipping
Bundle README (what the ZIP ships)
# magento2-33414

Community fix merged upstream into magento/magento2, adapted by magento.watch.
This is not a patch published by Adobe.

Pull request: https://github.com/magento/magento2/pull/33414
Issue: https://github.com/magento/magento2/issues/34523
Author: @4ctobias
Source commit: 691786378ecb3e07da3f174908735c89bc5ffc1d
Modifications: test files and documentation removed, paths rewritten relative to each Composer package.
Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code.
Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)

Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.

Sources

Łukasz Bajsarowicz
Built by

Łukasz Bajsarowicz, e-commerce architect

Magento and Adobe Commerce architecture, upgrades, performance and audits for merchants and agencies since 2015; magento.watch is the tooling I use on those projects.

Open source, maintained on weekends.