magento2-35842: Foreach warning in the grouped product _prepareProduct method
Community fix magento2-35842 merged into magento/magento2 on 2025-05-19, released in 2.4.9; applies cleanly to 6 releases from 2.4.8 to 2.4.8-p5.
Fixes the foreach warning in the grouped product _prepareProduct method edited
- Pull request title
- PHP8.1 type bugfix
- Pull request
- magento/magento2#35842
- Issues
- #35808 human
- Author
- @artskirk
- Merged
- 2025-05-19
- Fixed in
- 2.4.9
- Reported on
- —
- Categories
- Catalog/Product
- Components
- magento/module-grouped-product
Labels
- Area
- Framework
- Component
- GroupedProduct
- Priority
- P2
- Severity
- —
- Reported on (labels)
- —
Issue
Title and steps come from the upstream issue and pull request.
The upstream issue and pull request have no structured description.
Error signatures
- .CRITICAL: Exception: Warning: foreach() argument must be of type array|object, bool given
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 conflict 2.4.6-p1 conflict 2.4.6-p2 conflict 2.4.6-p3 conflict 2.4.6-p4 conflict 2.4.6-p5 conflict 2.4.6-p6 conflict 2.4.6-p7 conflict 2.4.6-p8 conflict 2.4.6-p9 conflict 2.4.6-p10 conflict 2.4.6-p11 conflict 2.4.6-p12 conflict 2.4.6-p13 conflict 2.4.6-p14 conflict 2.4.6-p15 conflict | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 conflict 2.4.7-p1 conflict 2.4.7-p2 conflict 2.4.7-p3 conflict 2.4.7-p4 conflict 2.4.7-p5 conflict 2.4.7-p6 conflict 2.4.7-p7 conflict 2.4.7-p8 conflict 2.4.7-p9 conflict 2.4.7-p10 conflict | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 clean 2.4.8-p1 clean 2.4.8-p2 clean 2.4.8-p3 clean 2.4.8-p4 clean 2.4.8-p5 clean | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 97.3%. Probability it is security relevant: 0.7%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 97.4%, refactor 1.1%, tests_only 0.4%, dependency 0.4%, docs_only 0.3%, feature 0.3% | 93.9% |
| Area | catalog | catalog 83.5%, admin 4.1%, other 4.0% | 65.9% |
| Reported version | unspecified | unspecified 32.0%, 2.4.6 2.2%, 2.4.7 1.8% | 9.8% |
| Scope | 0.36 of 2 | 0 67.7%, 1 28.2%, 2 4.1% | 30.9% |
| Risk | 0.20 of 2 | 0 85.4%, 1 9.1%, 2 5.5% | 61.0% |
| Worth backporting | 1.46 of 2 | 2 62.0%, 1 22.3%, 0 15.7% | 18.8% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-35842/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-35842 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/35842 Issue: https://github.com/magento/magento2/issues/35808 Author: @artskirk Source commit: fb9f5219cc2033bb062d4306e1241b9a00aaa387 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
