UPSTREAM FIX

magento2-36104: Product edit category tree not following the order set in Catalog

Community fix magento2-36104 merged into magento/magento2 on 2024-09-05, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.

Fixes the product edit category tree not following the order set in Catalog edited

Pull request title
Category selection tree in edit product is not in the same order as set in Catalog->Categories
Pull request
magento/magento2#36104
Issues
#36101 human
Author
@rogerdz
Merged
2024-09-05
Fixed in
2.4.8
Reported on
2.4.5
Categories
Catalog/Product
Components
magento/module-catalog

Labels

Area
Catalog, Product
Component
Catalog
Priority
P3
Severity
—
Reported on (labels)
2.4.5

Issue

Title and steps come from the upstream issue and pull request.

Description

The new category is at the bottom of the tree - suggesting the category tree under edit product is in creation order

Steps to reproduce

1. Create a new category under Catalog->Categories
2. Move the new category to the top of the tree
3. Edit a product and click on the Categories select... drop down

Expected result

- New category should be at the top of the tree as per display order set in Catalog->Categories

Actual result

The new category is at the bottom of the tree - suggesting the category tree under edit product is in creation order

Makes administering products difficult in large catalogues more difficult

Taken from the upstream issue.

Code match per tag

Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.

LineCode match per tagTests
2.4.6
2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean
2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data
2.4.7
2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean
2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: passes before and after (test does not cover the fix)unit: passes before and after
2.4.8
2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix
2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data
2.4.9
2.4.9 conflictcontains the fix
2.4.9: no test data

Triage

Model @cf/cloudflare/clef. Probability this is a bug fix: 97.6%. Probability it is security relevant: 0.5%.

Show the model's answers and probabilities
QuestionAnswerProbabilitiesConfidence
Change kindbugfixbugfix 96.4%, refactor 1.8%, tests_only 0.6%, feature 0.5%, dependency 0.3%, docs_only 0.3%91.6%
Areacatalogcatalog 72.5%, admin 25.0%, framework 0.7%52.9%
Reported version2.4.52.4.5 30.9%, unspecified 13.7%, 2.4.5-p1 2.1%10.8%
Scope0.59 of 20 48.9%, 1 42.9%, 2 8.1%14.6%
Risk0.29 of 20 73.8%, 1 23.3%, 2 2.9%40.0%
Worth backporting1.32 of 22 51.9%, 1 28.5%, 0 19.5%8.4%

Download

For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-36104/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.

Packages (1): magento/module-catalog
Bundle README (what the ZIP ships)
# magento2-36104

Community fix merged upstream into magento/magento2, adapted by magento.watch.
This is not a patch published by Adobe.

Pull request: https://github.com/magento/magento2/pull/36104
Issue: https://github.com/magento/magento2/issues/36101
Author: @rogerdz
Source commit: ab65056ef6a1ff833aa7720464ea12db9c9ed70b
Modifications: test files and documentation removed, paths rewritten relative to each Composer package.
Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code.
Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)

Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.

Sources

Łukasz Bajsarowicz
Built by

Łukasz Bajsarowicz, e-commerce architect

Magento and Adobe Commerce architecture, upgrades, performance and audits for merchants and agencies since 2015; magento.watch is the tooling I use on those projects.

Open source, maintained on weekends.