magento2-36263: Customer login showing a 404 page when the referer is a 404 URL
Community fix magento2-36263 merged into magento/magento2 on 2024-05-28, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
Fixes customer login showing a 404 page when the referer is a 404 URL edited
- Pull request title
- Customer is logged in but showing 404 error in frontend.
- Pull request
- magento/magento2#36263
- Issues
- #35838 human
- Author
- @rogerdz
- Merged
- 2024-05-28
- Fixed in
- 2.4.8
- Reported on
- —
- Categories
- Customer
- Components
- magento/module-customer
Labels
- Area
- Account
- Component
- LoginAsCustomerFrontendUi
- Priority
- P3
- Severity
- —
- Reported on (labels)
- 2.3.x, 2.4.x
Issue
Title and steps come from the upstream issue and pull request.
Description
Steps to reproduce
1. Add
/customer/account/loginPost/ in your magento url. ex-<http://magento240.local/customer/account/loginPost/>1. Now click on {**}S{*}*ign In**
1. Give login id and password.
Expected result
Actual result
Attached video: [Untitled_ Jul 29, 2022 3_00 PM.webm](https://user-images.githubusercontent.com/24892273/181730483-2e2f226d-7e83-4cf5-b101-49c7a7526ee1.webm)
Taken from the upstream issue.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: passes before and after (test does not cover the fix)unit: passes before and after |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 97.8%. Probability it is security relevant: 83.4%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 96.4%, refactor 1.5%, tests_only 0.7%, feature 0.6%, dependency 0.4%, docs_only 0.3% | 91.7% |
| Area | customer | customer 97.4%, frontend 0.8%, framework 0.5% | 94.1% |
| Reported version | unspecified | unspecified 29.2%, 2.4.0 4.5%, 2.4.4-p1 2.1% | 8.3% |
| Scope | 0.79 of 2 | 1 44.7%, 0 38.2%, 2 17.1% | 6.2% |
| Risk | 0.91 of 2 | 0 42.1%, 2 32.9%, 1 25.0% | 2.2% |
| Worth backporting | 1.45 of 2 | 2 57.8%, 1 29.9%, 0 12.3% | 15.7% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-36263/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-36263 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/36263 Issue: https://github.com/magento/magento2/issues/35838 Author: @rogerdz Source commit: 3d6a5dedea2d29da8933e81186ca61d0e8e2cf08 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
