magento2-36368: Cart gift options blocks loading the backend block context on the frontend
Community fix magento2-36368 merged into magento/magento2 on 2024-05-16, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
Fixes cart gift options blocks loading the backend block context on the frontend edited
- Pull request title
- Do not load backend block context on frontend
- Pull request
- magento/magento2#36368
- Issues
- #37617 pr-derived
- Author
- @ihor-sviziev
- Merged
- 2024-05-16
- Fixed in
- 2.4.8
- Reported on
- —
- Categories
- —
- Components
- magento/module-gift-message
Labels
- Area
- UI Framework
- Component
- Frontend
- Priority
- P2
- Severity
- —
- Reported on (labels)
- 2.4.x
Issue
Title and steps come from the upstream issue and pull request.
Description
Steps to reproduce
Magento\Backend\Block\Template\Context (because it uses backend session \Magento\Backend\Model\Session and other heavy objects)2. Try placing an order on the frontend.
Expected result:
✅ the class from the "backend" module shoudln't be loaded on frontend
Actual result:
❌ the class is getting loaded on frontend.
Taken from the upstream pull request.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 80.8%. Probability it is security relevant: 26.1%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 83.8%, refactor 13.8%, feature 0.8%, dependency 0.7%, tests_only 0.5%, docs_only 0.4% | 66.6% |
| Area | checkout | checkout 48.7%, frontend 29.1%, framework 10.2% | 24.3% |
| Reported version | unspecified | unspecified 23.8%, 2.4.6 3.1%, 2.4.8 2.7% | 5.5% |
| Scope | 0.33 of 2 | 0 72.5%, 1 22.3%, 2 5.2% | 36.8% |
| Risk | 0.43 of 2 | 0 70.3%, 1 16.4%, 2 13.3% | 30.8% |
| Worth backporting | 1.51 of 2 | 2 61.8%, 1 28.0%, 0 10.3% | 20.5% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-36368/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-36368 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/36368 Issue: https://github.com/magento/magento2/issues/37617 Author: @ihor-sviziev Source commit: e0b182613cb8b8a891f4b815ecdcfe0156fbfbaa Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
