UPSTREAM FIX

magento2-36818: Ambiguous created_at column error when filtering custom admin grids

Community fix magento2-36818 merged into magento/magento2 on 2024-06-16, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.

Fixes the ambiguous created_at column error when filtering custom admin grids edited

Pull request title: addFilterToMap function is not working for certain columns
Pull request: magento/magento2#36818
Issues: #36719 human
Author: @ananth-iyer
Merged: 2024-06-16
Fixed in: 2.4.8
Reported on: 2.4.5-p1
Categories: —
Components: magento/module-sales

Labels

Area: Framework
Component: DB
Priority: P2
Severity: —
Reported on (labels): 2.4.5-p1

Issue

Title and steps come from the upstream issue and pull request.

Description

applied filter mapping for created_at column not working. Getting errorSQLSTATE[23000]: Integrity constraint violation: 1052 Column 'created_at' in where clause is ambiguous.

Steps to reproduce

1. Create custom grid in admin based on table that has created_at column
2. Rewrite _initSelect to add join with another table that also has created_at column and after that apply filter map $this->addFilterToMap('created_at', 'main_table.created_at');
3. Apply filter on the grid by 'created_at' field or you can just apply addFieldToFilter by created_at column programmatically on you collection

Expected result

filtering of a collection by mapped column created_at works without errors and uses applied filter mapping

Actual result

applied filter mapping for created_at column not working. Getting errorSQLSTATE[23000]: Integrity constraint violation: 1052 Column 'created_at' in where clause is ambiguous.

Taken from the upstream issue.

Code match per tag

Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.

Line	Code match per tag	Tests
2.4.6	2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean	2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data
2.4.7	2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean	2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: fails before, passes afterintegration: fails before, passes after
2.4.8	2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix	2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data
2.4.9	2.4.9 file-missingcontains the fix	2.4.9: no test data

Triage

Model @cf/cloudflare/clef. Probability this is a bug fix: 97.8%. Probability it is security relevant: 0.6%.

Show the model's answers and probabilities

Question	Answer	Probabilities	Confidence
Change kind	bugfix	bugfix 95.0%, refactor 2.0%, tests_only 1.0%, feature 1.0%, dependency 0.7%, docs_only 0.4%	88.3%
Area	admin	admin 65.9%, framework 22.3%, checkout 5.9%	41.6%
Reported version	2.4.5-p1	2.4.5-p1 55.7%, 2.4.5 4.5%, 2.4.5-p2 1.3%	30.6%
Scope	0.98 of 2	1 47.3%, 0 27.2%, 2 25.5%	4.4%
Risk	0.57 of 2	0 55.1%, 1 32.3%, 2 12.5%	13.6%
Worth backporting	1.55 of 2	2 63.2%, 1 28.8%, 0 8.0%	23.4%

Download

For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-36818/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.

Bundle README (what the ZIP ships)

# magento2-36818

Community fix merged upstream into magento/magento2, adapted by magento.watch.
This is not a patch published by Adobe.

Pull request: https://github.com/magento/magento2/pull/36818
Issue: https://github.com/magento/magento2/issues/36719
Author: @ananth-iyer
Source commit: 01199a42e3c374a05f5839231e3a1c1489cdd8cf
Modifications: test files and documentation removed, paths rewritten relative to each Composer package.
Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code.
Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)

Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.