magento2-36949: Customer orders query ignoring filters when more than one is used
Community fix magento2-36949 merged into magento/magento2 on 2024-05-16, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
Fixes the customer orders query ignoring filters when more than one is used edited
- Pull request title
- Adding created_at, status and grand_total filters to customer Orders query and fixing multiple filters failure
- Pull request
- magento/magento2#36949
- Issues
- #38392 pr-derived
- Author
- @venchiarutti
- Merged
- 2024-05-16
- Fixed in
- 2.4.8
- Reported on
- —
- Categories
- GraphQL
- Components
- magento/module-sales-graph-ql
Labels
- Area
- Framework
- Component
- GraphQL
- Priority
- P2
- Severity
- —
- Reported on (labels)
- —
Issue
Title and steps come from the upstream issue and pull request.
Description
Fixing multiple filters bug in this query, when adding one more filter in the array for filterGroupBuilder addFilters it doesn´t apply all filters
Steps to reproduce
2. With the same customer, generate a customer token and call the customer Orders query
3. Create multiple orders to test filters
4. Use two or more filters to check if multiple are being applied
Taken from the upstream pull request.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 88.2%. Probability it is security relevant: 3.3%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 58.8%, feature 38.0%, refactor 1.8%, tests_only 0.6%, dependency 0.5%, docs_only 0.4% | 38.8% |
| Area | graphql_api | graphql_api 92.6%, customer 3.1%, checkout 1.9% | 83.8% |
| Reported version | unspecified | unspecified 18.8%, 2.4.6 3.6%, 2.4.6-p1 2.6% | 3.4% |
| Scope | 1.37 of 2 | 2 49.3%, 1 38.7%, 0 12.1% | 11.0% |
| Risk | 0.69 of 2 | 0 47.9%, 1 35.5%, 2 16.6% | 7.4% |
| Worth backporting | 1.51 of 2 | 2 62.2%, 1 26.1%, 0 11.7% | 20.3% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-36949/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-36949 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/36949 Issue: https://github.com/magento/magento2/issues/38392 Author: @venchiarutti Source commit: b015f9dde58de1466a596a330920f58ffc02dc58 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
