UPSTREAM FIX

magento2-37349: Google Gtag purchase event missing transaction prices and totals

Community fix magento2-37349 merged into magento/magento2 on 2024-07-04, released in 2.4.8; applies cleanly to 11 releases from 2.4.7 to 2.4.7-p10.

Fixes Google Gtag purchase event missing transaction prices and totals edited

Pull request title
GTag not send transaction prices and totals.
Pull request
magento/magento2#37349
Issues
#37348 human
Author
@Bashev
Merged
2024-07-04
Fixed in
2.4.8
Reported on
2.4.6
Categories
Order/Checkout
Components
magento/module-google-gtag

Labels

Area
Cart & Checkout
Component
—
Priority
P2
Severity
—
Reported on (labels)
2.4.6

Issue

Title and steps come from the upstream issue and pull request.

Description

![](https://user-images.githubusercontent.com/1854269/230713395-90d2cac1-c3a2-4295-a5c6-7d9d69991f8e.png)

Steps to reproduce

1. Enable Gtag (Store - Configuration - Sales - Google API - GTag - Enable and add Gtag Key
1. Add product to cart and finish an order.
1. On success page you need capture OrderTrackingData which was send to Google Tag.

Expected result

Currency need to be part of the order, not part of the "all" orders provided. Reference from Google Analytics docs: https://developers.google.com/analytics/devguides/collection/ga4/ecommerce?client*type=gtag#make_a_purchase_or_issue_a*refund

![](https://user-images.githubusercontent.com/1854269/230713701-3d4ba69a-7c8a-4aa2-a3ab-22beca7cc2c6.png)

Actual result

![](https://user-images.githubusercontent.com/1854269/230713395-90d2cac1-c3a2-4295-a5c6-7d9d69991f8e.png)

Taken from the upstream issue.

Code match per tag

Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.

LineCode match per tagTests
2.4.6
2.4.6 conflict 2.4.6-p1 conflict 2.4.6-p2 conflict 2.4.6-p3 conflict 2.4.6-p4 conflict 2.4.6-p5 conflict 2.4.6-p6 conflict 2.4.6-p7 conflict 2.4.6-p8 conflict 2.4.6-p9 conflict 2.4.6-p10 conflict 2.4.6-p11 conflict 2.4.6-p12 conflict 2.4.6-p13 conflict 2.4.6-p14 conflict 2.4.6-p15 conflict
2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data
2.4.7
2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean
2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: fails before, passes afterunit: fails before, passes after
2.4.8
2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix
2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data
2.4.9
2.4.9 conflictcontains the fix
2.4.9: no test data

Triage

Model @cf/cloudflare/clef. Probability this is a bug fix: 96.7%. Probability it is security relevant: 37.0%.

Show the model's answers and probabilities
QuestionAnswerProbabilitiesConfidence
Change kindbugfixbugfix 96.1%, refactor 2.0%, feature 0.6%, tests_only 0.5%, dependency 0.4%, docs_only 0.3%90.9%
Areacheckoutcheckout 41.5%, frontend 28.9%, other 24.0%21.6%
Reported version2.4.62.4.6 45.1%, unspecified 7.0%, 2.4.5-p2 2.9%20.3%
Scope1.04 of 21 76.0%, 2 14.0%, 0 10.0%41.0%
Risk0.62 of 20 49.5%, 1 39.1%, 2 11.3%11.7%
Worth backporting1.58 of 22 66.3%, 1 25.4%, 0 8.4%26.5%

Download

For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-37349/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.

Packages (1): magento/module-google-gtag
Bundle README (what the ZIP ships)
# magento2-37349

Community fix merged upstream into magento/magento2, adapted by magento.watch.
This is not a patch published by Adobe.

Pull request: https://github.com/magento/magento2/pull/37349
Issue: https://github.com/magento/magento2/issues/37348
Author: @Bashev
Source commit: 9e06503a3962b3ec1724d50204d8f5a7eef1cc89
Modifications: test files and documentation removed, paths rewritten relative to each Composer package.
Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code.
Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)

Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.

Sources

Łukasz Bajsarowicz
Built by

Łukasz Bajsarowicz, e-commerce architect

Magento and Adobe Commerce architecture, upgrades, performance and audits for merchants and agencies since 2015; magento.watch is the tooling I use on those projects.

Open source, maintained on weekends.