magento2-37457: Store th start tag in the admin visual swatch options table is not closed
Community fix magento2-37457 merged into magento/magento2 on 2024-07-04, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
Store th start tag in the admin visual swatch options table is not closed edited
- Pull request title
- Fix HTML syntax error in visual.phtml
- Pull request
- magento/magento2#37457
- Issues
- #38247 pr-derived
- Author
- @AntonKryvoruchko
- Merged
- 2024-07-04
- Fixed in
- 2.4.8
- Reported on
- —
- Categories
- —
- Components
- magento/module-swatches
Labels
- Area
- Other Developer Tools
- Component
- —
- Priority
- P2
- Severity
- —
- Reported on (labels)
- —
Issue
Title and steps come from the upstream issue and pull request.
The upstream issue and pull request have no structured description.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 93.6%. Probability it is security relevant: 4.6%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 92.3%, refactor 4.8%, docs_only 0.9%, tests_only 0.7%, feature 0.7%, dependency 0.6% | 82.6% |
| Area | admin | admin 56.0%, catalog 30.0%, frontend 7.6% | 32.7% |
| Reported version | unspecified | unspecified 20.0%, 2.4.6 3.3%, 2.4.6-p1 2.4% | 3.8% |
| Scope | 1.08 of 2 | 1 68.3%, 2 20.0%, 0 11.7% | 28.1% |
| Risk | 0.63 of 2 | 1 56.9%, 0 40.2%, 2 2.9% | 23.0% |
| Worth backporting | 1.00 of 2 | 2 36.0%, 0 36.0%, 1 27.9% | 0.7% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-37457/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-37457 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/37457 Issue: https://github.com/magento/magento2/issues/38247 Author: @AntonKryvoruchko Source commit: 830f1a3af82f5bf20f9f99417e05aaeedc244407 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
