UPSTREAM FIX

magento2-37717: Product media gallery GraphQL response is not sorted by image position

Community fix magento2-37717 merged into magento/magento2 on 2024-07-25, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.

Product media gallery GraphQL response is not sorted by image position edited

Pull request title
Product Media Gallery GQL response is not sorted by image position
Pull request
magento/magento2#37717
Issues
#37671 human
Author
@Kannakiraj123
Merged
2024-07-25
Fixed in
2.4.8
Reported on
—
Categories
Catalog/Product
Components
magento/module-catalog

Labels

Area
Product
Component
Image
Priority
P2
Severity
—
Reported on (labels)
2.4.x

Issue

Title and steps come from the upstream issue and pull request.

Description

Gallery images are sorted by their IDs.

Steps to reproduce

1. Edit the prdouct
2. Add images
3. Save it
4. edit the same product and this time drag the last image to the very first
5. save the productproduct

Expected result

GraphQl response should return the gallery sorted by their position.

Actual result

Gallery images are sorted by their IDs.

Taken from the upstream issue.

Code match per tag

Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.

LineCode match per tagTests
2.4.6
2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean
2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data
2.4.7
2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean
2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data
2.4.8
2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix
2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data
2.4.9
2.4.9 conflictcontains the fix
2.4.9: no test data

Triage

Model @cf/cloudflare/clef. Probability this is a bug fix: 97.7%. Probability it is security relevant: 0.6%.

Show the model's answers and probabilities
QuestionAnswerProbabilitiesConfidence
Change kindbugfixbugfix 96.9%, refactor 1.4%, tests_only 0.5%, feature 0.5%, dependency 0.3%, docs_only 0.3%92.8%
Areagraphql_apigraphql_api 58.1%, catalog 36.3%, frontend 1.5%39.4%
Reported versionunspecifiedunspecified 50.7%, 2.4.7-p4 1.1%, 2.4.7-p6 1.1%25.2%
Scope0.32 of 20 73.3%, 1 21.4%, 2 5.3%38.0%
Risk0.27 of 20 76.4%, 1 20.2%, 2 3.4%43.8%
Worth backporting1.49 of 22 61.8%, 1 25.7%, 0 12.5%19.5%

Download

For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-37717/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.

Packages (1): magento/module-catalog
Bundle README (what the ZIP ships)
# magento2-37717

Community fix merged upstream into magento/magento2, adapted by magento.watch.
This is not a patch published by Adobe.

Pull request: https://github.com/magento/magento2/pull/37717
Issue: https://github.com/magento/magento2/issues/37671
Author: @Kannakiraj123
Source commit: 921460ad649b21b4d542ee7320cc21b286f82ebb
Modifications: test files and documentation removed, paths rewritten relative to each Composer package.
Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code.
Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)

Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.

Sources

Łukasz Bajsarowicz
Built by

Łukasz Bajsarowicz, e-commerce architect

Magento and Adobe Commerce architecture, upgrades, performance and audits for merchants and agencies since 2015; magento.watch is the tooling I use on those projects.

Open source, maintained on weekends.