magento2-37852: Layered navigation filter item count uses item and items incorrectly
Community fix magento2-37852 merged into magento/magento2 on 2024-07-04, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
Layered navigation filter item count uses item and items incorrectly edited
- Pull request title
- Fix wording of filter item on layered navigation
- Pull request
- magento/magento2#37852
- Issues
- #38789 pr-derived
- Author
- @yogesh-valiya
- Merged
- 2024-07-04
- Fixed in
- 2.4.8
- Reported on
- —
- Categories
- Catalog/Product
- Components
- magento/module-layered-navigation
Labels
- Area
- Catalog
- Component
- Catalog
- Priority
- P3
- Severity
- —
- Reported on (labels)
- 2.4.x
Issue
Title and steps come from the upstream issue and pull request.
Description
item and items are incorrectly used in the layered navigation filter item.Taken from the upstream pull request.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 88.6%. Probability it is security relevant: 0.5%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 94.7%, refactor 2.0%, docs_only 1.9%, feature 0.6%, tests_only 0.5%, dependency 0.4% | 87.6% |
| Area | frontend | frontend 62.4%, catalog 28.5%, other 4.7% | 39.8% |
| Reported version | unspecified | unspecified 15.0%, 2.4.6 4.6%, 2.4.6-p1 2.4% | 2.3% |
| Scope | 0.15 of 2 | 0 87.5%, 1 10.3%, 2 2.2% | 66.6% |
| Risk | 0.23 of 2 | 0 78.4%, 1 20.2%, 2 1.3% | 48.4% |
| Worth backporting | 0.52 of 2 | 0 60.9%, 1 26.2%, 2 13.0% | 18.3% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-37852/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-37852 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/37852 Issue: https://github.com/magento/magento2/issues/38789 Author: @yogesh-valiya Source commit: 830cd1f7bb0dc98cd6a7f75da863809e43d09a07 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
