magento2-37918: Credit memo with a negative qty to refund will refund the order discount
Community fix magento2-37918 merged into magento/magento2 on 2025-12-12, released in 2.4.9; applies cleanly to 33 releases from 2.4.6 to 2.4.8-p5.
Credit memo with a negative qty to refund will refund the order discount edited
- Pull request title
- Refund with negative qty alway refund discound
- Pull request
- magento/magento2#37918
- Issues
- #37917 human
- Author
- @rogerdz
- Merged
- 2025-12-12
- Fixed in
- 2.4.9
- Reported on
- —
- Categories
- Order/Checkout
- Components
- magento/module-sales
Labels
- Area
- Product
- Component
- Sales
- Priority
- P2
- Severity
- —
- Reported on (labels)
- 2.4.x
Issue
Title and steps come from the upstream issue and pull request.
Description
Steps to reproduce
2. Create invoice for order
3. Create credit memo with qty to refund negative
Expected result
Actual result
Taken from the upstream issue.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: fails before, passes afterunit: fails before, passes after |
| 2.4.8 | 2.4.8 clean 2.4.8-p1 clean 2.4.8-p2 clean 2.4.8-p3 clean 2.4.8-p4 clean 2.4.8-p5 clean | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: test files do not apply to this releaseunit: could not run before, could not run after |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 97.3%. Probability it is security relevant: 0.8%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 96.5%, refactor 1.3%, tests_only 1.1%, feature 0.4%, dependency 0.4%, docs_only 0.4% | 91.7% |
| Area | admin | admin 55.6%, checkout 33.3%, other 3.0% | 34.0% |
| Reported version | unspecified | unspecified 53.8%, 2.4.7-p6 1.2%, 2.4.6 1.2% | 28.3% |
| Scope | 0.45 of 2 | 0 64.5%, 1 25.7%, 2 9.8% | 23.8% |
| Risk | 0.53 of 2 | 0 67.4%, 2 20.6%, 1 12.0% | 26.6% |
| Worth backporting | 1.54 of 2 | 2 62.6%, 1 28.5%, 0 8.8% | 22.2% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-37918/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-37918 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/37918 Issue: https://github.com/magento/magento2/issues/37917 Author: @rogerdz Source commit: 96ba350864ea39252a603732695f891ca4620ad7 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
