UPSTREAM FIX

magento2-37959: Stored payment accounts list shows a PayPal Account header for every provider

Community fix magento2-37959 merged into magento/magento2 on 2024-05-28, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.

Stored payment accounts list shows a PayPal Account header for every provider edited

Pull request title: Change header wording to apply to other payment providers, resolves #35622
Pull request: magento/magento2#37959
Issues: —
Author: @cjnewbs
Merged: 2024-05-28
Fixed in: 2.4.8
Reported on: —
Categories: —
Components: magento/module-vault

Labels

Area: —
Component: —
Priority: —
Severity: —
Reported on (labels): —

Issue

Title and steps come from the upstream issue and pull request.

Description

In issue #35622 it has been identified that that the core template only refers to PayPal, however this functionality is being utilised by other payment providers. This PR changes the text and translations for PayPal Account to Account so that other providers can use this functionality without having to override the core template.

Steps to reproduce

1. Log-in as a customer with payment accounts stored in the Magento_Vault module
2. The header that the token shows under should read Account instead of PayPal Account

Taken from the upstream pull request.

Code match per tag

Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.

Line	Code match per tag	Tests
2.4.6	2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean	2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data
2.4.7	2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean	2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data
2.4.8	2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix	2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data
2.4.9	2.4.9 conflictcontains the fix	2.4.9: no test data

Triage

Model @cf/cloudflare/clef. Probability this is a bug fix: 57.7%. Probability it is security relevant: 1.1%.

Show the model's answers and probabilities

Question	Answer	Probabilities	Confidence
Change kind	bugfix	bugfix 81.1%, refactor 11.8%, cleanup 2.7%, feature 1.9%, docs_only 1.7%, tests_only 0.5%, dependency 0.3%	61.9%
Area	checkout	checkout 50.3%, frontend 27.4%, customer 18.4%	27.2%
Reported version	unspecified	unspecified 6.8%, 2.4.6 5.3%, 2.4.7 3.3%	0.8%
Scope	0.58 of 2	0 51.4%, 1 39.4%, 2 9.2%	14.2%
Risk	0.36 of 2	0 68.2%, 1 27.4%, 2 4.4%	31.3%
Worth backporting	0.60 of 2	0 57.1%, 1 25.8%, 2 17.2%	13.3%

Download

For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-37959/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.

Bundle README (what the ZIP ships)

# magento2-37959

Community fix merged upstream into magento/magento2, adapted by magento.watch.
This is not a patch published by Adobe.

Pull request: https://github.com/magento/magento2/pull/37959
Author: @cjnewbs
Source commit: afafd167299ad8a5b0384665f8041ec5ad53a6f5
Modifications: test files and documentation removed, paths rewritten relative to each Composer package.
Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code.
Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)

Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.