magento2-38410: Maintenance:status prints enabled or disabled instead of active or not active
Community fix magento2-38410 merged into magento/magento2 on 2024-05-16, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
maintenance:status prints enabled or disabled instead of active or not active edited
- Pull request title
- Changed "active" to "enabled" in bin/magento maintenance:status command
- Pull request
- magento/magento2#38410
- Issues
- #38486 pr-derived
- Author
- @YevhenZvieriev
- Merged
- 2024-05-16
- Fixed in
- 2.4.8
- Reported on
- —
- Categories
- —
- Components
- magento/module-backend
Labels
- Area
- Other Developer Tools
- Component
- Framework/Code
- Priority
- P3
- Severity
- —
- Reported on (labels)
- 2.4.x
Issue
Title and steps come from the upstream issue and pull request.
Description
bin/magento maintenance:enable and bin/magento maintenance:disable. But when executing the command bin/magento maintenance:status, I got Status: maintenance mode is active.Taken from the upstream pull request.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: fails before, passes afterunit: fails before, passes after |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 27.9%. Probability it is security relevant: 0.5%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 56.8%, refactor 29.1%, docs_only 5.9%, tests_only 3.9%, feature 3.6%, dependency 0.7% | 29.7% |
| Area | framework | framework 81.5%, other 10.9%, admin 5.0% | 63.3% |
| Reported version | unspecified | unspecified 23.7%, 2.4.6 5.0%, 2.4.6-p1 3.7% | 5.7% |
| Scope | 0.37 of 2 | 0 66.6%, 1 29.7%, 2 3.8% | 29.9% |
| Risk | 0.06 of 2 | 0 94.8%, 1 4.0%, 2 1.2% | 85.2% |
| Worth backporting | 0.43 of 2 | 0 68.4%, 1 20.1%, 2 11.5% | 28.2% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38410/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-38410 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/38410 Issue: https://github.com/magento/magento2/issues/38486 Author: @YevhenZvieriev Source commit: 338ab50992a441f716fa77ea606c4f5d1083e626 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
