UPSTREAM FIX
magento2-38427: The tier price stays after converting a simple product to a configurable product
Community fix magento2-38427 merged into magento/magento2 on 2024-05-16, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
The tier price stays after converting a simple product to a configurable product edited
- Pull request title
- Tier Price is not being deleted from Configurable Product
- Pull request
- magento/magento2#38427
- Issues
- #38390 human
- Author
- @zeel1012
- Merged
- 2024-05-16
- Fixed in
- 2.4.8
- Reported on
- 2.4.6-p2
- Categories
- Catalog/Product, Price/Tax
- Components
- magento/module-configurable-product
Labels
- Area
- Catalog
- Component
- Pricing
- Priority
- P2
- Severity
- —
- Reported on (labels)
- 2.4.6-p2
Issue
Title and steps come from the upstream issue and pull request.
Description
The tier price of the configurable product is not deleted when a product is converted from a simple product to a configurable product. It is showing the tier price of a configurable product as a minimum price.
Steps to reproduce
1. Create a simple product with a tier price.
2. Edit that simple product and convert it into a configurable product by creating some variants with a price greater than the tier price and make sure that any variant should not have any tier price.
3. Observe in the database that table
4. Visit the particular product on a listing page and product page and observe the price.
2. Edit that simple product and convert it into a configurable product by creating some variants with a price greater than the tier price and make sure that any variant should not have any tier price.
3. Observe in the database that table
catalog_product_entity_tier_price still has the entry for the particular product with the tier price.4. Visit the particular product on a listing page and product page and observe the price.
Expected result
The tier price of the configurable product should also get deleted when a product is converted from a simple product to a configurable product. It should show the minimum price of the variants instead of a tier price of the parent configurable product at the frontend.
Actual result
The tier price of the configurable product is not deleted when a product is converted from a simple product to a configurable product. It is showing the tier price of a configurable product as a minimum price.
Taken from the upstream issue.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: test could not run before the patch, passes afterunit: could not run before, passes after |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 98.3%. Probability it is security relevant: 0.7%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 95.9%, refactor 1.4%, feature 1.1%, tests_only 0.9%, dependency 0.4%, docs_only 0.4% | 90.3% |
| Area | catalog | catalog 85.3%, admin 4.2%, framework 3.7% | 69.4% |
| Reported version | 2.4.6-p2 | 2.4.6-p2 68.2%, 2.4.6 2.0%, 2.4.6-p1 1.4% | 46.1% |
| Scope | 0.73 of 2 | 0 48.1%, 1 31.1%, 2 20.9% | 5.7% |
| Risk | 1.11 of 2 | 2 48.3%, 0 37.6%, 1 14.0% | 9.2% |
| Worth backporting | 1.58 of 2 | 2 64.0%, 1 29.6%, 0 6.4% | 25.3% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38427/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-38427 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/38427 Issue: https://github.com/magento/magento2/issues/38390 Author: @zeel1012 Source commit: 4470413df05c7a64e3ca83b60c6ebffb95ecce53 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
