magento2-38433: ProductRepository::getById loads a product twice for a string and int store ID
Community fix magento2-38433 merged into magento/magento2 on 2024-05-28, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
ProductRepository::getById loads a product twice for a string and int store ID edited
- Pull request title
- ProductRepository function GetById does not create the correct cache key
- Pull request
- magento/magento2#38433
- Issues
- #38384 human
- Author
- @MaximGns
- Merged
- 2024-05-28
- Fixed in
- 2.4.8
- Reported on
- 2.4.6-p3
- Categories
- Cache, Catalog/Product
- Components
- magento/module-catalog
Labels
- Area
- Product
- Component
- Cache
- Priority
- P2
- Severity
- —
- Reported on (labels)
- 2.4.6-p3
Issue
Title and steps come from the upstream issue and pull request.
Description
Steps to reproduce
Retrieve the product by using the repositories method 'getById' with same parameters except the $storeId should be once string and the other time it should be and integer
$product = $this->productRepository->getById(1, false, '1'); $product = $this->productRepository->getById(1, false, 1);Product is retrieved twice from database
Expected result
getById method with same store value (string or int). The second time the product should be retrieved from memory.Actual result
Taken from the upstream issue.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: passes before and after (test does not cover the fix)unit: passes before and after |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 97.9%. Probability it is security relevant: 0.8%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 95.2%, refactor 1.6%, tests_only 1.5%, feature 0.7%, dependency 0.5%, docs_only 0.5% | 88.8% |
| Area | catalog | catalog 64.0%, framework 29.1%, admin 2.0% | 42.3% |
| Reported version | 2.4.6-p3 | 2.4.6-p3 67.9%, 2.4.6 3.0%, 2.4.6-p4 0.8% | 45.6% |
| Scope | 0.86 of 2 | 1 68.3%, 0 23.1%, 2 8.6% | 29.0% |
| Risk | 0.20 of 2 | 0 83.0%, 1 13.4%, 2 3.5% | 56.4% |
| Worth backporting | 1.31 of 2 | 2 51.4%, 1 27.7%, 0 20.9% | 7.7% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38433/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-38433 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/38433 Issue: https://github.com/magento/magento2/issues/38384 Author: @MaximGns Source commit: 2aa6cfc10a2de15ce9b2d0eb923bd5ee76296bcc Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
