magento2-38449: Form method attribute is not used when a form has an element with name method
Community fix magento2-38449 merged into magento/magento2 on 2024-05-16, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
Form method attribute is not used when a form has an element with name method edited
- Pull request title
- Fix issues with Customer Data when form contains element with name `method`
- Pull request
- magento/magento2#38449
- Issues
- #38484 pr-derived
- Author
- @lbajsarowicz
- Merged
- 2024-05-16
- Fixed in
- 2.4.8
- Reported on
- —
- Categories
- —
- Components
- magento/module-catalog, magento/module-customer
Labels
- Area
- Framework
- Component
- Frontend
- Priority
- P1
- Severity
- —
- Reported on (labels)
- 2.4.x
Issue
Title and steps come from the upstream issue and pull request.
Description
<form method=""> value in customer-data.js (Magento_Customer) is glitchy and when there's an element with name="method" in the submitted form, the event.target.method refers to element, not attribute.Steps to reproduce
2. Open Browser console and replace
name="" of any element (e.g. "Remember me") to name="method".3. Set breakpoint at
customer-data.min.js line after $(document).on('submit', function(event) {. 4. Expect that
if () section (1 line below) uses <form method=""> - not just created element.Taken from the upstream pull request.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 97.7%. Probability it is security relevant: 5.0%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 97.4%, refactor 1.2%, tests_only 0.4%, feature 0.4%, dependency 0.3%, docs_only 0.3% | 93.8% |
| Area | frontend | frontend 52.8%, customer 39.3%, framework 2.6% | 35.3% |
| Reported version | unspecified | unspecified 22.7%, 2.4.6 3.4%, 2.4.6-p1 2.3% | 5.0% |
| Scope | 0.72 of 2 | 0 43.4%, 1 41.3%, 2 15.2% | 7.4% |
| Risk | 0.41 of 2 | 0 64.4%, 1 29.9%, 2 5.7% | 26.2% |
| Worth backporting | 1.57 of 2 | 2 66.4%, 1 24.5%, 0 9.2% | 26.3% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38449/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-38449 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/38449 Issue: https://github.com/magento/magento2/issues/38484 Author: @lbajsarowicz Source commit: bcb6fc6f5c2a3bac12a9ed5378b41952632d2081 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
