magento2-38539: Redirect loop when the base URL contains uppercase characters
Community fix magento2-38539 merged into magento/magento2 on 2024-11-01, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
Fixes the redirect loop when the base URL contains uppercase characters edited
- Pull request title
- Redirect loop when URL have uppercase
- Pull request
- magento/magento2#38539
- Issues
- #38538 human
- Author
- @rogerdz
- Merged
- 2024-11-01
- Fixed in
- 2.4.8
- Reported on
- —
- Categories
- —
- Components
- magento/module-config
Labels
- Area
- Account
- Component
- Url
- Priority
- P3
- Severity
- —
- Reported on (labels)
- 2.4.x
Issue
Title and steps come from the upstream issue and pull request.
Description
!https://github.com/magento/magento2/assets/78783748/90e91b39-6f89-49c3-99c5-a2d2ebba718c!
Steps to reproduce
1. Clean cache: php bin/magento cache:clean
1. Go to homepage
Expected result
Actual result
!https://github.com/magento/magento2/assets/78783748/90e91b39-6f89-49c3-99c5-a2d2ebba718c!
Taken from the upstream issue.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: fails before, passes afterunit: fails before, passes after |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 97.4%. Probability it is security relevant: 10.7%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 96.6%, refactor 1.2%, tests_only 0.8%, feature 0.7%, dependency 0.4%, docs_only 0.3% | 92.1% |
| Area | framework | framework 61.5%, admin 23.9%, other 5.0% | 36.1% |
| Reported version | unspecified | unspecified 44.8%, 2.4.6 1.2%, 2.4.8-p4 1.1% | 19.5% |
| Scope | 0.47 of 2 | 0 61.3%, 1 30.4%, 2 8.2% | 21.3% |
| Risk | 0.37 of 2 | 0 70.1%, 1 22.4%, 2 7.5% | 32.1% |
| Worth backporting | 1.53 of 2 | 2 64.6%, 1 23.4%, 0 12.0% | 23.0% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38539/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-38539 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/38539 Issue: https://github.com/magento/magento2/issues/38538 Author: @rogerdz Source commit: b890117ac8604af283c9d1233dc435b6f60b9a0b Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
