UPSTREAM FIX

magento2-38693: Cron_schedule keeping entries for jobs that no longer exist

Community fix magento2-38693 merged into magento/magento2 on 2024-07-04, released in 2.4.8.

Fixes cron_schedule keeping entries for jobs that no longer exist edited

Pull request title: Cleanup of cron_schedule database table doesn't cleanup non-existing jobs
Pull request: magento/magento2#38693
Issues: #38217 human
Author: @fredden
Merged: 2024-07-04
Fixed in: 2.4.8
Reported on: 2.4.6-p3
Categories: Cron
Components: magento/module-cron

Labels

Area: Catalog
Component: Cron
Priority: P2
Severity: —
Reported on (labels): 2.4.6-p3

Issue

Title and steps come from the upstream issue and pull request.

Description

See that there are still jobs inventory_in_store_pickup_sales_send_order_notified_emails in the table with status success and being older then 60 minutes. Those don't get cleaned up because the MSI modules are no longer active and calling getJobs() [over here](https://github.com/magento/magento2/blob/2.4.6-p3/app/code/Magento/Cron/Observer/ProcessCronQueueObserver.php#L577) doesn't return jobs from inactive (or removed) modules.

Steps to reproduce

Explanation below how to trigger this with a cronjob from inside core Magento. But the most likely cases will come from 3rd party modules containing cronjobs, that were installed for a while and then removed again.

1. Have a Magento shop with MSI modules enabled
2. Have a working crontab and have it running for a couple of hours
3. Inspect the cron_schedule table and notice that the job inventory_in_store_pickup_sales_send_order_notified_emails is mentioned many times with status success
4. Now, disable all MSI modules in app/etc/config.php and run bin/magento setup:upgrade
5. Keep the crontab running for a few more hours
6. Inspect your cron_schedule table again

Expected result

It's expected that all jobs that were successful and having run more than 60 minutes ago are removed from the cron_schedule table.

Actual result

Taken from the upstream issue.

Code match per tag

Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.

Line	Code match per tag	Tests
2.4.6	2.4.6 conflict 2.4.6-p1 conflict 2.4.6-p2 conflict 2.4.6-p3 conflict 2.4.6-p4 conflict 2.4.6-p5 conflict 2.4.6-p6 conflict 2.4.6-p7 conflict 2.4.6-p8 conflict 2.4.6-p9 conflict 2.4.6-p10 conflict 2.4.6-p11 conflict 2.4.6-p12 conflict 2.4.6-p13 conflict 2.4.6-p14 conflict 2.4.6-p15 conflict	2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data
2.4.7	2.4.7 conflict 2.4.7-p1 conflict 2.4.7-p2 conflict 2.4.7-p3 conflict 2.4.7-p4 conflict 2.4.7-p5 conflict 2.4.7-p6 conflict 2.4.7-p7 conflict 2.4.7-p8 conflict 2.4.7-p9 conflict 2.4.7-p10 conflict	2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data
2.4.8	2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix	2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data
2.4.9	2.4.9 conflictcontains the fix	2.4.9: no test data

Triage

Model @cf/cloudflare/clef. Probability this is a bug fix: 90.0%. Probability it is security relevant: 0.7%.

Show the model's answers and probabilities

Question	Answer	Probabilities	Confidence
Change kind	bugfix	bugfix 78.9%, feature 16.2%, refactor 2.5%, tests_only 1.0%, dependency 0.8%, docs_only 0.5%	57.9%
Area	framework	framework 94.5%, catalog 1.5%, other 1.1%	87.9%
Reported version	2.4.6-p3	2.4.6-p3 63.4%, 2.4.6 3.1%, 2.4.6-p4 1.1%	39.8%
Scope	1.04 of 2	1 44.9%, 2 29.5%, 0 25.7%	3.1%
Risk	0.32 of 2	0 75.8%, 1 16.7%, 2 7.4%	41.2%
Worth backporting	1.36 of 2	2 53.5%, 1 29.4%, 0 17.1%	10.3%

Download

For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38693/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.

No checked release lacks this fix with a clean code match, so no bundle is offered.

Bundle README (what the ZIP ships)

# magento2-38693

Community fix merged upstream into magento/magento2, adapted by magento.watch.
This is not a patch published by Adobe.

Pull request: https://github.com/magento/magento2/pull/38693
Issue: https://github.com/magento/magento2/issues/38217
Author: @fredden
Source commit: 9ebddc600c0a9828981626e86a03ca813b587305
Modifications: test files and documentation removed, paths rewritten relative to each Composer package.
Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code.
Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)

Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.