magento2-38696: Admin Password update
Community fix magento2-38696 merged into magento/magento2 on 2024-12-30, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
- Pull request title
- admin Password update.
- Pull request
- magento/magento2#38696
- Issues
- #38352 human
- Author
- @Franciscof-Serfe
- Merged
- 2024-12-30
- Fixed in
- 2.4.8
- Reported on
- 2.4.4
- Categories
- Admin, Customer
- Components
- magento/module-backend
Labels
- Area
- Account
- Component
- Admin
- Priority
- P2
- Severity
- —
- Reported on (labels)
- 2.4.4
Issue
Title and steps come from the upstream issue and pull request.
Description
- ❌ You're still see the "change password" page, so you think that Magento asks you to change a password one more time
-
Steps to reproduce
- He got asked for 2fa auth, and he puts the code
- He gots redirected to a "change password page" (that actually has a lot of other fields). Admin changes his password, clicks "Save" button.
Expected result
- ✅ You should be redirected to the home admin page (because your main flow was a log in flow, not the change password)
Actual result
- ❌ You're still see the "change password" page, so you think that Magento asks you to change a password one more time
-
Taken from the upstream issue.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: test files do not apply to this releaseintegration: could not run before, could not run after |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 82.3%. Probability it is security relevant: 22.8%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 83.7%, feature 5.7%, refactor 5.5%, cleanup 2.2%, tests_only 1.7%, docs_only 0.8%, dependency 0.5% | 65.8% |
| Area | admin | admin 89.1%, customer 6.8%, framework 1.2% | 77.0% |
| Reported version | 2.4.4 | 2.4.4 46.9%, 2.4.4-p1 5.1%, unspecified 3.5% | 21.7% |
| Scope | 1.16 of 2 | 2 39.0%, 1 37.5%, 0 23.5% | 2.2% |
| Risk | 0.55 of 2 | 0 63.9%, 2 19.1%, 1 17.0% | 21.1% |
| Worth backporting | 1.00 of 2 | 2 34.4%, 0 34.0%, 1 31.6% | 0.1% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38696/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-38696 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/38696 Issue: https://github.com/magento/magento2/issues/38352 Author: @Franciscof-Serfe Source commit: bec65335bf8616cea43b0ec66fce192901e25a09 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
