magento2-38713: Admin sticky header page action buttons floating left instead of right
Community fix magento2-38713 merged into magento/magento2 on 2024-09-11, released in 2.4.8; applies cleanly to 11 releases from 2.4.7 to 2.4.7-p10.
Fixes admin sticky header page action buttons floating left instead of right edited
- Pull request title
- Admin: Page Actions Buttons floating left instead of right
- Pull request
- magento/magento2#38713
- Issues
- #38701 human
- Author
- @pawan
- Merged
- 2024-09-11
- Fixed in
- 2.4.8
- Reported on
- 2.4.7
- Categories
- —
- Components
- magento/magento2-base
Labels
- Area
- Account
- Component
- View
- Priority
- P2
- Severity
- —
- Reported on (labels)
- 2.4.7
Issue
Title and steps come from the upstream issue and pull request.
Description
Steps to reproduce
- Go to Stores >> Settings >> Configuration OR Customers >> All Customers >> Add New Customer
- Now scroll page
- On sticky header, Page Actions Buttons floating left instead of right
Expected result
<img width="1345" alt="Screenshot 2024-05-07 at 11 58 03 AM" src="https://github.com/magento/magento2/assets/22196227/e2df443d-9748-4b3d-b984-43da8c749246"]
Actual result
[img width="979" alt="Screenshot 2024-05-07 at 11 56 13 AM" src="https://github.com/magento/magento2/assets/22196227/8a21d9a4-8960-4352-a394-c1b322a7a0d9"]
Taken from the upstream issue.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 conflict 2.4.6-p1 conflict 2.4.6-p2 conflict 2.4.6-p3 conflict 2.4.6-p4 conflict 2.4.6-p5 conflict 2.4.6-p6 conflict 2.4.6-p7 conflict 2.4.6-p8 conflict 2.4.6-p9 conflict 2.4.6-p10 conflict 2.4.6-p11 conflict 2.4.6-p12 conflict 2.4.6-p13 conflict 2.4.6-p14 conflict 2.4.6-p15 conflict | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 96.9%. Probability it is security relevant: 0.5%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 96.1%, refactor 1.6%, docs_only 0.6%, tests_only 0.6%, feature 0.6%, dependency 0.5% | 90.8% |
| Area | admin | admin 92.3%, frontend 2.8%, customer 1.4% | 83.3% |
| Reported version | 2.4.7 | 2.4.7 50.5%, 2.4.6-p1 2.3%, 2.4.7-p1 1.7% | 25.0% |
| Scope | 0.35 of 2 | 0 69.4%, 1 25.8%, 2 4.8% | 32.6% |
| Risk | 0.23 of 2 | 0 79.3%, 1 18.8%, 2 2.0% | 49.6% |
| Worth backporting | 0.41 of 2 | 0 67.9%, 1 23.7%, 2 8.4% | 28.6% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38713/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-38713 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/38713 Issue: https://github.com/magento/magento2/issues/38701 Author: @pawan Source commit: 2ac7f56562f2890e2e39cfe4636ff0c46a9c8a59 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
