UPSTREAM FIX
magento2-38819: Instant purchase picks a non-cheapest shipping method for configurable products
Community fix magento2-38819 merged into magento/magento2 on 2024-07-14, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
Instant purchase picks a non-cheapest shipping method for configurable products edited
- Pull request title
- Instant purchase "cheapest shipping" broken for configurable products
- Pull request
- magento/magento2#38819
- Issues
- #38811 human
- Author
- @Tomasito665
- Merged
- 2024-07-14
- Fixed in
- 2.4.8
- Reported on
- 2.4.7
- Categories
- —
- Components
- magento/module-instant-purchase
Labels
- Area
- —
- Component
- —
- Priority
- P1
- Severity
- —
- Reported on (labels)
- 2.4.7
Issue
Title and steps come from the upstream issue and pull request.
Description
The order is placed using the $6.00 In-Store Delivery shipment method, which is NOT the cheapest shipment method.
{quote}[!NOTE]
{quote}
{quote}As seen in the screenshot, with my setup, the order placement does not finish successfully and ends with a "Quote does not have Pickup Location assigned" error. The cause of this error is irrelevant to the bug described in this issue. However, the fact that it gives *this* error in particular shows that the instant purchase flow attempts to place the order using the In-Store Delivery shipment method, which is sufficient to demonstrate the bug.
{quote}
[img width="1136" alt="ActualBehavior_2of2" src="https://github.com/magento/magento2/assets/12563382/bce0144a-5faf-4f2e-9487-4da90f8315df">
{quote}[!NOTE]
{quote}
{quote}As seen in the screenshot, with my setup, the order placement does not finish successfully and ends with a "Quote does not have Pickup Location assigned" error. The cause of this error is irrelevant to the bug described in this issue. However, the fact that it gives *this* error in particular shows that the instant purchase flow attempts to place the order using the In-Store Delivery shipment method, which is sufficient to demonstrate the bug.
{quote}
[img width="1136" alt="ActualBehavior_2of2" src="https://github.com/magento/magento2/assets/12563382/bce0144a-5faf-4f2e-9487-4da90f8315df">
Steps to reproduce
* On the frontend page, make sure you are logged in with the previously created customer account.
* Click on the “Search entire store here…” textbook, type “Chaz Kangeroo Hoodie”, and press Enter.
* There should be only one result. Click on it to open the product details page for “Chaz Kangeroo Hoodie”.
* Click on the Instant Purchase button. You’ll see a confirmation popup with Shipping Method: Cheapest price.
* Click on OK to confirm the purchase.
* Click on the “Search entire store here…” textbook, type “Chaz Kangeroo Hoodie”, and press Enter.
* There should be only one result. Click on it to open the product details page for “Chaz Kangeroo Hoodie”.
* Click on the Instant Purchase button. You’ll see a confirmation popup with Shipping Method: Cheapest price.
* Click on OK to confirm the purchase.
Expected result
The order is placed using the cheapest shipment method, which, as we saw in step 6, is the $5.00 Flat Rate shipment method.
<img width="1124" alt="Expected behavior" src="https://github.com/magento/magento2/assets/12563382/541e573b-0e3a-4174-b066-1f1c4f99160f"]
<img width="1124" alt="Expected behavior" src="https://github.com/magento/magento2/assets/12563382/541e573b-0e3a-4174-b066-1f1c4f99160f"]
Actual result
The order is placed using the $6.00 In-Store Delivery shipment method, which is NOT the cheapest shipment method.
{quote}[!NOTE]
{quote}
{quote}As seen in the screenshot, with my setup, the order placement does not finish successfully and ends with a "Quote does not have Pickup Location assigned" error. The cause of this error is irrelevant to the bug described in this issue. However, the fact that it gives *this* error in particular shows that the instant purchase flow attempts to place the order using the In-Store Delivery shipment method, which is sufficient to demonstrate the bug.
{quote}
[img width="1136" alt="ActualBehavior_2of2" src="https://github.com/magento/magento2/assets/12563382/bce0144a-5faf-4f2e-9487-4da90f8315df">
{quote}[!NOTE]
{quote}
{quote}As seen in the screenshot, with my setup, the order placement does not finish successfully and ends with a "Quote does not have Pickup Location assigned" error. The cause of this error is irrelevant to the bug described in this issue. However, the fact that it gives *this* error in particular shows that the instant purchase flow attempts to place the order using the In-Store Delivery shipment method, which is sufficient to demonstrate the bug.
{quote}
[img width="1136" alt="ActualBehavior_2of2" src="https://github.com/magento/magento2/assets/12563382/bce0144a-5faf-4f2e-9487-4da90f8315df">
Taken from the upstream issue.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 98.0%. Probability it is security relevant: 0.8%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 96.3%, refactor 1.2%, cleanup 0.9%, feature 0.5%, tests_only 0.4%, dependency 0.3%, docs_only 0.3% | 91.5% |
| Area | checkout | checkout 90.7%, other 2.2%, catalog 2.0% | 79.9% |
| Reported version | 2.4.7 | 2.4.7 57.7%, 2.4.7-p1 2.2%, unspecified 1.9% | 32.9% |
| Scope | 0.71 of 2 | 0 47.7%, 1 34.0%, 2 18.4% | 6.4% |
| Risk | 1.12 of 2 | 2 45.4%, 0 32.9%, 1 21.7% | 4.2% |
| Worth backporting | 1.57 of 2 | 2 64.4%, 1 28.5%, 0 7.1% | 25.2% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38819/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-38819 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/38819 Issue: https://github.com/magento/magento2/issues/38811 Author: @Tomasito665 Source commit: 1c931b9672600ff0c4b32cc414f0ce5006f229d1 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
