magento2-38886: Uses the Object Manager to create ModeConfigured in the CSP ConfigManager
Community fix magento2-38886 merged into magento/magento2 on 2024-12-24, released in 2.4.8; applies cleanly to 21 releases from 2.4.6-p6 to 2.4.7-p10.
Uses the Object Manager to create ModeConfigured in the CSP ConfigManager edited
- Pull request title
- Object Manager not used for Magento\Csp\Model\Mode\Data\ModeConfigured
- Pull request
- magento/magento2#38886
- Issues
- #38875 human
- Author
- @pmzandbergen
- Merged
- 2024-12-24
- Fixed in
- 2.4.8
- Reported on
- —
- Categories
- —
- Components
- magento/module-csp
Labels
- Area
- Framework
- Component
- Framework/Code
- Priority
- P2
- Severity
- —
- Reported on (labels)
- 2.4.x
Issue
Title and steps come from the upstream issue and pull request.
The upstream issue and pull request have no structured description.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 conflict 2.4.6-p1 conflict 2.4.6-p2 conflict 2.4.6-p3 conflict 2.4.6-p4 conflict 2.4.6-p5 conflict 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: fails before, passes afterunit: fails before, passes after |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 66.2%. Probability it is security relevant: 14.2%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 53.1%, refactor 44.2%, feature 1.0%, tests_only 0.9%, dependency 0.5%, docs_only 0.3% | 37.3% |
| Area | framework | framework 89.5%, other 4.4%, admin 2.1% | 77.7% |
| Reported version | unspecified | unspecified 26.3%, 2.4.6 2.0%, 2.4.8 1.9% | 6.6% |
| Scope | 0.83 of 2 | 1 47.1%, 0 35.1%, 2 17.8% | 6.5% |
| Risk | 0.28 of 2 | 0 74.4%, 1 23.3%, 2 2.4% | 41.2% |
| Worth backporting | 1.10 of 2 | 2 39.1%, 1 31.7%, 0 29.2% | 0.8% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38886/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-38886 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/38886 Issue: https://github.com/magento/magento2/issues/38875 Author: @pmzandbergen Source commit: bcb6d69789b9efd484a769acd3e4382a4fb4c019 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
