magento2-38924: Admin image uploads with capital letter extensions fail
Community fix magento2-38924 merged into magento/magento2 on 2024-08-17, released in 2.4.8; applies cleanly to 11 releases from 2.4.7 to 2.4.7-p10.
Fixes the issue where admin image uploads with capital letter extensions fail edited
- Pull request title
- [Bug] Magento 2.4.7 doesn't allow product photo's with capital letter file extension.
- Pull request
- magento/magento2#38924
- Issues
- #38831 human
- Author
- @monteshot
- Merged
- 2024-08-17
- Fixed in
- 2.4.8
- Reported on
- 2.4.7
- Categories
- Admin
- Components
- magento/module-backend
Labels
- Area
- Admin UI
- Component
- File
- Priority
- P1
- Severity
- —
- Reported on (labels)
- 2.4.7
Issue
Title and steps come from the upstream issue and pull request.
Description
Steps to reproduce
2. Try to upload a picture with e.g. filename
DSCN0018.JPG. The upload will fail.3. Change the filename to
DSCN0018.jpg. The upload succeeds.<img width="778" alt="Screenshot 2024-06-14 at 18 47 20" src="https://github.com/magento/magento2/assets/1392118/f63e59a0-0475-47be-af2d-2daacb8aa1f6">
Expected result
Actual result
Taken from the upstream issue.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 conflict 2.4.6-p1 conflict 2.4.6-p2 conflict 2.4.6-p3 conflict 2.4.6-p4 conflict 2.4.6-p5 conflict 2.4.6-p6 conflict 2.4.6-p7 conflict 2.4.6-p8 conflict 2.4.6-p9 conflict 2.4.6-p10 conflict 2.4.6-p11 conflict 2.4.6-p12 conflict 2.4.6-p13 conflict 2.4.6-p14 conflict 2.4.6-p15 conflict | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 98.1%. Probability it is security relevant: 1.8%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 95.8%, refactor 1.4%, tests_only 0.9%, feature 0.7%, dependency 0.6%, docs_only 0.6% | 90.1% |
| Area | admin | admin 76.3%, catalog 9.8%, frontend 8.0% | 54.2% |
| Reported version | 2.4.7 | 2.4.7 57.6%, 2.4.7-p7 1.7%, 2.4.7-p1 1.7% | 32.7% |
| Scope | 0.18 of 2 | 0 85.2%, 1 11.3%, 2 3.6% | 60.9% |
| Risk | 0.21 of 2 | 0 80.9%, 1 17.3%, 2 1.8% | 52.8% |
| Worth backporting | 1.67 of 2 | 2 74.0%, 1 18.7%, 0 7.3% | 38.3% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38924/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-38924 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/38924 Issue: https://github.com/magento/magento2/issues/38831 Author: @monteshot Source commit: dc85981ddda85d75f1c2781e9e2e1c50e3976ae8 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
