UPSTREAM FIX

magento2-38925: Date custom options ignore the configured date field order

Community fix magento2-38925 merged into magento/magento2 on 2024-09-05, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.

Fixes the issue where date custom options ignore the configured date field order edited

Pull request title: Date and Time Format for Custom Option Not Working
Pull request: magento/magento2#38925
Issues: #32990 human
Author: @NitrogenUA
Merged: 2024-09-05
Fixed in: 2.4.8
Reported on: 2.4.2
Categories: Catalog/Product
Components: magento/module-catalog

Labels

Area: Catalog
Component: Catalog
Priority: P3
Severity: —
Reported on (labels): 2.4.2

Issue

Title and steps come from the upstream issue and pull request.

Description

1. See result Below

Steps to reproduce

1. [Follow these Steps](https://docs.magento.com/user-guide/stores/attribute-date-time-options.html) to Configure Date format
2. Check Date of Product with Custom Options of type Date

Expected result

1. Date Format Should Change on Front-end

Actual result

1. See result Below

https://user-images.githubusercontent.com/51072292/117776610-353bae00-b255-11eb-90f2-37dab6fe7f0c.mp4

---
Please provide [Severity](https://devdocs.magento.com/guides/v2.4/contributor-guide/contributing.html#backlog) assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

- [ ] Severity: S0 _- Affects critical data or functionality and leaves users without workaround._
- [ *] Severity: S1 _- Affects critical data or functionality and forces users to employ a workaround._
- [ ] Severity: S2 _- Affects non-critical data or functionality and forces users to employ a workaround._
- [ ] Severity: S3 _- Affects non-critical data or functionality and does not force users to employ a workaround._
- [ ] Severity: S4 _- Affects aesthetics, professional look and feel, “quality” or “usability”._

Taken from the upstream issue.

Code match per tag

Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.

Line	Code match per tag	Tests
2.4.6	2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean	2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data
2.4.7	2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean	2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data
2.4.8	2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix	2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data
2.4.9	2.4.9 conflictcontains the fix	2.4.9: no test data

Triage

Model @cf/cloudflare/clef. Probability this is a bug fix: 97.4%. Probability it is security relevant: 0.5%.

Show the model's answers and probabilities

Question	Answer	Probabilities	Confidence
Change kind	bugfix	bugfix 97.0%, tests_only 0.9%, refactor 0.8%, feature 0.8%, dependency 0.3%, docs_only 0.2%	93.0%
Area	catalog	catalog 76.4%, frontend 13.7%, admin 5.6%	55.0%
Reported version	2.4.2	2.4.2 61.6%, 2.4.2-p2 6.0%, 2.4.2-p1 4.5%	38.0%
Scope	0.93 of 2	1 36.9%, 0 35.3%, 2 27.9%	0.7%
Risk	0.29 of 2	0 73.4%, 1 23.8%, 2 2.8%	39.4%
Worth backporting	1.66 of 2	2 73.4%, 1 18.8%, 0 7.8%	37.0%

Download

For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38925/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.

Bundle README (what the ZIP ships)

# magento2-38925

Community fix merged upstream into magento/magento2, adapted by magento.watch.
This is not a patch published by Adobe.

Pull request: https://github.com/magento/magento2/pull/38925
Issue: https://github.com/magento/magento2/issues/32990
Author: @NitrogenUA
Source commit: 5adc83d40b22caed795838ecf8bfdcefacef4ab0
Modifications: test files and documentation removed, paths rewritten relative to each Composer package.
Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code.
Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)

Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.