magento2-38926: File-type custom options losing price and extensions on product import
Community fix magento2-38926 merged into magento/magento2 on 2024-09-05, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
Fixes file-type custom options losing price and extensions on product import edited
- Pull request title
- Issue at product import when provided with custom options-type: file (Created Product does not contain price for custom-option and show only the first file type extension provided)
- Pull request
- magento/magento2#38926
- Issues
- #38805 human
- Author
- @yaroslav-kozar
- Merged
- 2024-09-05
- Fixed in
- 2.4.8
- Reported on
- 2.4.7
- Categories
- Import/Export
- Components
- magento/module-catalog-import-export
Labels
- Area
- Import / Export
- Component
- ImportExport
- Priority
- P2
- Severity
- —
- Reported on (labels)
- 2.4.7
Issue
Title and steps come from the upstream issue and pull request.
Description
Steps to reproduce
2. Add the necessary data for the product along with custom_options.
3. Add the type: file and other data for the custom_options column. Make sure to add more than one file_extension attribute.
4. Navigate to System>Import.
5. Choose Entity type: Products and Import behaviors: Add/Update. Leave the remaining settings as default. (separators: ",")
6. Validate and Import the Product.
7. Check the created product customization options section on the edit product page. The price is missing and file extension show only the first extension provided in the CSV.
Expected result
Actual result
Taken from the upstream issue.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: fails before, passes afterunit: fails before, passes after |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 98.0%. Probability it is security relevant: 0.6%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 97.2%, tests_only 0.9%, refactor 0.7%, feature 0.6%, dependency 0.3%, docs_only 0.3% | 93.5% |
| Area | catalog | catalog 64.4%, admin 15.4%, other 11.2% | 37.4% |
| Reported version | 2.4.7 | 2.4.7 58.5%, 2.4.7-p1 2.1%, 2.4.7-p6 1.5% | 33.7% |
| Scope | 0.66 of 2 | 1 46.4%, 0 43.7%, 2 9.9% | 12.4% |
| Risk | 0.18 of 2 | 0 85.5%, 1 10.8%, 2 3.7% | 61.6% |
| Worth backporting | 1.54 of 2 | 2 63.9%, 1 25.8%, 0 10.3% | 22.9% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38926/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-38926 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/38926 Issue: https://github.com/magento/magento2/issues/38805 Author: @yaroslav-kozar Source commit: a4eab4cd6cebe6170dca81ef0202da310aa9c2d7 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
