magento2-38927: A default attribute option cannot be unselected
Community fix magento2-38927 merged into magento/magento2 on 2024-12-13, released in 2.4.8.
Fixes the issue where a default attribute option cannot be unselected edited
- Pull request title
- Default Product Attribute Settings Issue
- Pull request
- magento/magento2#38927
- Issues
- #38703 human
- Author
- @rostilos
- Merged
- 2024-12-13
- Fixed in
- 2.4.8
- Reported on
- 2.4.7
- Categories
- Catalog/Product
- Components
- magento/module-catalog, magento/module-swatches
Labels
- Area
- Performance
- Component
- Attributes
- Priority
- P1
- Severity
- —
- Reported on (labels)
- 2.4.7
Issue
Title and steps come from the upstream issue and pull request.
Description
Scenario 2: Once a default is set, after we deselect it , its never saved
Steps to reproduce
2. Select Stores in admin side panel
3. Select product under attributes
Scenario 1:
4. Select an attribute to edit which has Catalog Input Type for Store Owner is Visual swatch or dropdown
5. If the "is default" option is selected, there is no way to set the attribute to no longer have a default option
Scenario 2:
6. Select an attribute to edit which has Catalog Input Type for Store Owner is Multiple Select
7. If you deselect the default option then save or save and continue it still is set as the default
8. If you select multiple options as default and deselect the default options then save or save and continue all the options
are selected as default
Expected result
Scenario 2: If you deselect the default option then save or save and continue it should removed from default
Actual result
Scenario 2: Once a default is set, after we deselect it , its never saved
Taken from the upstream issue.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 conflict 2.4.6-p1 conflict 2.4.6-p2 conflict 2.4.6-p3 conflict 2.4.6-p4 conflict 2.4.6-p5 conflict 2.4.6-p6 conflict 2.4.6-p7 conflict 2.4.6-p8 conflict 2.4.6-p9 conflict 2.4.6-p10 conflict 2.4.6-p11 conflict 2.4.6-p12 conflict 2.4.6-p13 conflict 2.4.6-p14 conflict 2.4.6-p15 conflict | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 conflict 2.4.7-p1 conflict 2.4.7-p2 conflict 2.4.7-p3 conflict 2.4.7-p4 conflict 2.4.7-p5 conflict 2.4.7-p6 conflict 2.4.7-p7 conflict 2.4.7-p8 conflict 2.4.7-p9 conflict 2.4.7-p10 conflict | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 96.4%. Probability it is security relevant: 0.6%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 91.3%, feature 5.5%, refactor 1.3%, tests_only 1.0%, dependency 0.5%, docs_only 0.4% | 80.3% |
| Area | catalog | catalog 59.1%, admin 36.9%, frontend 2.3% | 41.1% |
| Reported version | 2.4.7 | 2.4.7 59.6%, 2.4.7-p1 1.6%, unspecified 1.2% | 34.9% |
| Scope | 1.02 of 2 | 1 38.6%, 2 31.7%, 0 29.7% | 0.7% |
| Risk | 0.75 of 2 | 1 68.6%, 0 28.0%, 2 3.3% | 32.6% |
| Worth backporting | 1.53 of 2 | 2 62.5%, 1 28.2%, 0 9.3% | 21.9% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38927/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
No checked release lacks this fix with a clean code match, so no bundle is offered.
Bundle README (what the ZIP ships)
# magento2-38927 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/38927 Issue: https://github.com/magento/magento2/issues/38703 Author: @rostilos Source commit: da5e7cc0b723b0ba4183a26c29742cdc47a32e45 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
