UPSTREAM FIX

magento2-38951: Admin errors from references to extjs files that no longer exist

Community fix magento2-38951 merged into magento/magento2 on 2024-09-05, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.

Fixes admin errors from references to extjs files that no longer exist edited

Pull request title
Remove references to files from extjs which got removed in e1ccdb…
Pull request
magento/magento2#38951
Issues
#38960 pr-derived
Author
@hostep
Merged
2024-09-05
Fixed in
2.4.8
Reported on
—
Categories
Admin
Components
magento/module-backend, magento/module-email, magento/module-theme, magento/module-widget

Labels

Area
Framework
Component
UiComponents
Priority
P1
Severity
—
Reported on (labels)
2.4.x

Issue

Title and steps come from the upstream issue and pull request.

Description

While running Magento 2.4-develop locally, I noticed some errors both in my brower's console and the var/log/system.log file:

Steps to reproduce

1. Open the backoffice
2. See if there are errors in your browsers console about trying to load css files from extjs
3. See in your var/log/system.log if there are errors about empty less files from extjs

Taken from the upstream pull request.

Code match per tag

Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.

LineCode match per tagTests
2.4.6
2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean
2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data
2.4.7
2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean
2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data
2.4.8
2.4.8 file-missingcontains the fix 2.4.8-p1 file-missingcontains the fix 2.4.8-p2 file-missingcontains the fix 2.4.8-p3 file-missingcontains the fix 2.4.8-p4 file-missingcontains the fix 2.4.8-p5 file-missingcontains the fix
2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data
2.4.9
2.4.9 file-missingcontains the fix
2.4.9: no test data

Triage

Model @cf/cloudflare/clef. Probability this is a bug fix: 82.0%. Probability it is security relevant: 0.5%.

Show the model's answers and probabilities
QuestionAnswerProbabilitiesConfidence
Change kindbugfixbugfix 86.5%, refactor 11.0%, tests_only 0.9%, dependency 0.7%, docs_only 0.5%, feature 0.4%71.2%
Areaadminadmin 73.8%, frontend 11.1%, framework 9.8%50.6%
Reported versionunspecifiedunspecified 21.0%, 2.4.7 5.4%, 2.4.7-p1 3.2%4.5%
Scope0.76 of 21 53.7%, 0 35.1%, 2 11.2%13.6%
Risk0.40 of 20 61.7%, 1 36.2%, 2 2.1%26.8%
Worth backporting1.34 of 22 55.5%, 1 22.6%, 0 21.8%11.1%

Download

For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38951/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.

Packages (4): magento/module-backend, magento/module-email, magento/module-theme, magento/module-widget
Bundle README (what the ZIP ships)
# magento2-38951

Community fix merged upstream into magento/magento2, adapted by magento.watch.
This is not a patch published by Adobe.

Pull request: https://github.com/magento/magento2/pull/38951
Issue: https://github.com/magento/magento2/issues/38960
Author: @hostep
Source commit: 7a0cacf9033f60051d24c5cbcd2b2d3982fd6ba9
Modifications: test files and documentation removed, paths rewritten relative to each Composer package.
Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code.
Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)

Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.

Sources

Łukasz Bajsarowicz
Built by

Łukasz Bajsarowicz, e-commerce architect

Magento and Adobe Commerce architecture, upgrades, performance and audits for merchants and agencies since 2015; magento.watch is the tooling I use on those projects.

Open source, maintained on weekends.