magento2-38972: Changes the JS console log timestamp to 24 hour format with timezone
Community fix magento2-38972 merged into magento/magento2 on 2024-12-04, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
Changes the JS console log timestamp to 24 hour format with timezone edited
- Pull request title
- Improved date format in js console: switch from 12 hour to 24 hour fo…
- Pull request
- magento/magento2#38972
- Issues
- #38983 pr-derived
- Author
- @hostep
- Merged
- 2024-12-04
- Fixed in
- 2.4.8
- Reported on
- —
- Categories
- —
- Components
- magento/module-ui
Labels
- Area
- UI Framework
- Component
- UiComponents
- Priority
- P2
- Severity
- —
- Reported on (labels)
- 2.4.x
Issue
Title and steps come from the upstream issue and pull request.
Description
For example:
<img width="816" alt="Screenshot 2024-07-24 at 19 44 48" src="https://github.com/user-attachments/assets/f1d3555c-75ed-411d-8c75-c3f4c3524dd8">
Steps to reproduce
2. Manually introduce a bug in the code: open the file
app/code/Magento/Checkout/view/frontend/web/js/view/summary/abstract-total.js and add this problematic line:--- a/app/code/Magento/Checkout/view/frontend/web/js/view/summary/abstract-total.js
+++ b/app/code/Magento/Checkout/view/frontend/web/js/view/summary/abstract-total.js
@@ -13,6 +13,8 @@ define([
'use strict';
return Component.extend({
+ problem: window.unexistingProp.unexistingProp,
+
/**
* @param {*} price
* @return {*|String}3. Have a Magento shop setup with at least one saleable product in the database4. On the frontend, put the product in your cart and go to the checkout
5. Look at your browsers inspector
Before the changes, it outputs something like:
[2024-07-24 07:43:24]After the changes, it outputs something like:
[2024-07-24 19:43:24+02:00]Taken from the upstream pull request.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 35.9%. Probability it is security relevant: 0.7%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 62.6%, feature 23.5%, refactor 8.9%, tests_only 2.8%, docs_only 1.1%, dependency 1.0% | 34.7% |
| Area | frontend | frontend 52.1%, framework 31.6%, other 5.8% | 29.0% |
| Reported version | unspecified | unspecified 18.0%, 2.4.8 5.0%, 2.4.8-p1 3.3% | 3.5% |
| Scope | 0.50 of 2 | 0 59.0%, 1 31.9%, 2 9.1% | 18.8% |
| Risk | 0.28 of 2 | 0 74.4%, 1 23.3%, 2 2.3% | 41.3% |
| Worth backporting | 0.68 of 2 | 0 51.3%, 1 29.1%, 2 19.6% | 7.9% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-38972/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-38972 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/38972 Issue: https://github.com/magento/magento2/issues/38983 Author: @hostep Source commit: 2fc5ca5d62b142d56ab9f8a38668ef1dc978e72d Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
