UPSTREAM FIX

magento2-39004: A required file field fails after a file is chosen

Community fix magento2-39004 merged into magento/magento2 on 2025-01-07, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.

Fixes the issue where a required file field fails after a file is chosen edited

Pull request title
Ui Component File Field
Pull request
magento/magento2#39004
Issues
#38908 human
Author
@Mohamed-Asar
Merged
2025-01-07
Fixed in
2.4.8
Reported on
—
Categories
Admin
Components
magento/module-ui

Labels

Area
UI Framework
Component
UiComponents
Priority
P3
Severity
—
Reported on (labels)
2.4.x

Issue

Title and steps come from the upstream issue and pull request.

Description

Even if we select a file, the validation fails, like no file was selected.
h
![346533395-e1667aa9-ca43-4516-8b18-53967a2fc682](https://github.com/magento/magento2/assets/20971693/fe04b194-d969-42de-8fc2-cfa475efffd1)

Steps to reproduce

Add the following field in a ui component form:
<file name="file">
            <settings>
                <label translate="true">Select File to Import</label>
                <dataScope>file</dataScope>
                <validation>
                    <rule name="required-entry" xsi:type="boolean">true</rule>
                </validation>
            </settings>
        </file>

Expected result

The form is submitted without error.

Actual result

Even if we select a file, the validation fails, like no file was selected.
h
![346533395-e1667aa9-ca43-4516-8b18-53967a2fc682](https://github.com/magento/magento2/assets/20971693/fe04b194-d969-42de-8fc2-cfa475efffd1)

Taken from the upstream issue.

Code match per tag

Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.

LineCode match per tagTests
2.4.6
2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean
2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data
2.4.7
2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean
2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data
2.4.8
2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix
2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data
2.4.9
2.4.9 conflictcontains the fix
2.4.9: no test data

Triage

Model @cf/cloudflare/clef. Probability this is a bug fix: 97.8%. Probability it is security relevant: 0.6%.

Show the model's answers and probabilities
QuestionAnswerProbabilitiesConfidence
Change kindbugfixbugfix 97.1%, refactor 1.1%, tests_only 0.6%, feature 0.5%, dependency 0.4%, docs_only 0.3%93.1%
Areaadminadmin 70.0%, framework 16.3%, frontend 9.7%45.9%
Reported versionunspecifiedunspecified 42.6%, 2.4.6 2.2%, 2.4.8 1.7%17.6%
Scope0.84 of 21 58.5%, 0 28.8%, 2 12.7%16.2%
Risk0.63 of 21 58.5%, 0 39.3%, 2 2.2%24.5%
Worth backporting1.49 of 22 60.2%, 1 28.4%, 0 11.4%18.4%

Download

For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-39004/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.

Packages (1): magento/module-ui
Bundle README (what the ZIP ships)
# magento2-39004

Community fix merged upstream into magento/magento2, adapted by magento.watch.
This is not a patch published by Adobe.

Pull request: https://github.com/magento/magento2/pull/39004
Issue: https://github.com/magento/magento2/issues/38908
Author: @Mohamed-Asar
Source commit: 24f10d4304f218a8c3f852930c2d045fae8bf835
Modifications: test files and documentation removed, paths rewritten relative to each Composer package.
Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code.
Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)

Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.

Sources

Łukasz Bajsarowicz
Built by

Łukasz Bajsarowicz, e-commerce architect

Magento and Adobe Commerce architecture, upgrades, performance and audits for merchants and agencies since 2015; magento.watch is the tooling I use on those projects.

Open source, maintained on weekends.