magento2-39525: Cart price rule SKU condition not taking leading zeros into account
Community fix magento2-39525 merged into magento/magento2 on 2025-04-16, released in 2.4.9; applies cleanly to 17 releases from 2.4.7 to 2.4.8-p5.
Fixes cart price rule SKU condition not taking leading zeros into account edited
- Pull request title
- Cart price rule with condition SKU doesn't take into account the "leading zeros" in the SKU (sku: 01234 is the same as 1234)
- Pull request
- magento/magento2#39525
- Issues
- #37919 human
- Author
- @magentoabu
- Merged
- 2025-04-16
- Fixed in
- 2.4.9
- Reported on
- 2.4.4
- Categories
- —
- Components
- magento/module-rule
Labels
- Area
- Admin UI
- Component
- —
- Priority
- P3
- Severity
- —
- Reported on (labels)
- 2.4.4
Issue
Title and steps come from the upstream issue and pull request.
Description
Steps to reproduce
2. Create product with SKU: 01234
3. Create CART PRICE RULE (for example):
- Specific coupon
- Coupon code: TESTSKU
- ACTION: percent of product price discount, 50% discount amount)
- Apply the rule only to cart items ... (SKU is 01234)
5. Go to shop front and add product SKU 1234 to CART
6. On the cart page enter the coupon code TESTSKU
Expected result
Actual result
Taken from the upstream issue.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 conflict 2.4.6-p1 conflict 2.4.6-p2 conflict 2.4.6-p3 conflict 2.4.6-p4 conflict 2.4.6-p5 conflict 2.4.6-p6 conflict 2.4.6-p7 conflict 2.4.6-p8 conflict 2.4.6-p9 conflict 2.4.6-p10 conflict 2.4.6-p11 conflict 2.4.6-p12 conflict 2.4.6-p13 conflict 2.4.6-p14 conflict 2.4.6-p15 conflict | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: fails before, passes afterunit: fails before, passes after |
| 2.4.8 | 2.4.8 clean 2.4.8-p1 clean 2.4.8-p2 clean 2.4.8-p3 clean 2.4.8-p4 clean 2.4.8-p5 clean | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: fails before, passes afterunit: fails before, passes after |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 97.4%. Probability it is security relevant: 1.3%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 96.7%, refactor 1.2%, tests_only 0.8%, feature 0.5%, dependency 0.4%, docs_only 0.3% | 92.1% |
| Area | checkout | checkout 48.2%, framework 21.6%, other 11.7% | 20.6% |
| Reported version | 2.4.4 | 2.4.4 51.1%, unspecified 4.6%, 2.4.4-p1 1.7% | 25.8% |
| Scope | 0.60 of 2 | 0 51.7%, 1 37.1%, 2 11.2% | 12.6% |
| Risk | 1.01 of 2 | 2 34.6%, 0 33.8%, 1 31.6% | 0.1% |
| Worth backporting | 1.50 of 2 | 2 59.5%, 1 31.3%, 0 9.3% | 19.0% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-39525/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-39525 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/39525 Issue: https://github.com/magento/magento2/issues/37919 Author: @magentoabu Source commit: d52ec0102a1c397230e6a0bec0ca77fb800901c0 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
