UPSTREAM FIX

magento2-39670: 404 on a product page when the category path contains the URL key

Community fix magento2-39670 merged into magento/magento2 on 2025-04-29, released in 2.4.9; applies cleanly to 33 releases from 2.4.6 to 2.4.8-p5.

Fixes the 404 on a product page when the category path contains the URL key edited

Pull request title
Product page gives error because of url rewrites
Pull request
magento/magento2#39670
Issues
#35371 human
Author
@Himsoft
Merged
2025-04-29
Fixed in
2.4.9
Reported on
2.4.1
Categories
Catalog/Product
Components
magento/module-catalog-url-rewrite

Labels

Area
Catalog, SEO / Metadata
Component
Catalog
Priority
P2
Severity
—
Reported on (labels)
2.4.1, 2.4.x

Issue

Title and steps come from the upstream issue and pull request.

Description

1. There is 404 error (on 2.4.3 or newer version) or 500 error (on older version than 2.4.3).

Steps to reproduce

1. Go to Test Sub Category.
2. Click on product Test.

Expected result

1. The product page is loaded successfully.

Actual result

1. There is 404 error (on 2.4.3 or newer version) or 500 error (on older version than 2.4.3).

Looks like on line 173 in \Magento\CatalogUrlRewrite\Model\Storage\DynamicStorage function str_replace should not be used. We fixed it on our installation by changing that line to this:
$categoryPath = substr($requestPath, 0, -1 * strlen('/' . $productUrl));
---
Please provide [Severity](https://devdocs.magento.com/guides/v2.4/contributor-guide/contributing.html#backlog) assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

- [ ] Severity: S0 _- Affects critical data or functionality and leaves users without workaround._
- [ ] Severity: S1 _- Affects critical data or functionality and forces users to employ a workaround._
- [x] Severity: S2 _- Affects non-critical data or functionality and forces users to employ a workaround._
- [ ] Severity: S3 _- Affects non-critical data or functionality and does not force users to employ a workaround._
- [ ] Severity: S4 _- Affects aesthetics, professional look and feel, “quality” or “usability”._

Taken from the upstream issue.

Code match per tag

Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.

LineCode match per tagTests
2.4.6
2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean
2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data
2.4.7
2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean
2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: fails before, passes afterunit: fails before, passes after
2.4.8
2.4.8 clean 2.4.8-p1 clean 2.4.8-p2 clean 2.4.8-p3 clean 2.4.8-p4 clean 2.4.8-p5 clean
2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: fails before, passes afterunit: fails before, passes after
2.4.9
2.4.9 conflictcontains the fix
2.4.9: no test data

Triage

Model @cf/cloudflare/clef. Probability this is a bug fix: 98.0%. Probability it is security relevant: 0.7%.

Show the model's answers and probabilities
QuestionAnswerProbabilitiesConfidence
Change kindbugfixbugfix 97.3%, refactor 1.1%, tests_only 0.6%, feature 0.4%, dependency 0.3%, docs_only 0.3%93.7%
Areacatalogcatalog 75.4%, other 8.6%, framework 5.2%52.3%
Reported version2.4.32.4.3 34.7%, 2.4.1 25.1%, unspecified 3.2%17.8%
Scope0.63 of 20 47.2%, 1 42.4%, 2 10.4%12.0%
Risk0.44 of 20 62.4%, 1 31.3%, 2 6.2%23.8%
Worth backporting1.68 of 22 73.1%, 1 21.9%, 0 4.9%37.8%

Download

For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-39670/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.

Packages (1): magento/module-catalog-url-rewrite
Bundle README (what the ZIP ships)
# magento2-39670

Community fix merged upstream into magento/magento2, adapted by magento.watch.
This is not a patch published by Adobe.

Pull request: https://github.com/magento/magento2/pull/39670
Issue: https://github.com/magento/magento2/issues/35371
Author: @Himsoft
Source commit: ca76908eab0142b2396f847068fe0a1c327728e4
Modifications: test files and documentation removed, paths rewritten relative to each Composer package.
Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code.
Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)

Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.

Sources

Łukasz Bajsarowicz
Built by

Łukasz Bajsarowicz, e-commerce architect

Magento and Adobe Commerce architecture, upgrades, performance and audits for merchants and agencies since 2015; magento.watch is the tooling I use on those projects.

Open source, maintained on weekends.