UPSTREAM FIX
magento2-39687: Wrong order total as the round function is not applied to the discount
Community fix magento2-39687 merged into magento/magento2 on 2025-05-20, released in 2.4.9; applies cleanly to 33 releases from 2.4.6 to 2.4.8-p5.
Wrong order total as the round function is not applied to the discount edited
- Pull request title
- Wrong Order total, the round is not applied to the price calculation.
- Pull request
- magento/magento2#39687
- Issues
- #38455 human
- Author
- @YuriyYavorskiy
- Merged
- 2025-05-20
- Fixed in
- 2.4.9
- Reported on
- 2.4.6-p3
- Categories
- Price/Tax
- Components
- magento/module-sales-rule
Labels
- Area
- Tax
- Component
- Tax
- Priority
- P2
- Severity
- —
- Reported on (labels)
- 2.4.6-p3
Issue
Title and steps come from the upstream issue and pull request.
Description
Magento not doing the round function when calculating price_after_discount, discount_amount and taxes amount for the second product added to the cart.
resulting in total 3667,51 when reproducing the error using method 1 and 3667,5 when reproducing the error using method 2.
resulting in total 3667,51 when reproducing the error using method 1 and 3667,5 when reproducing the error using method 2.
Steps to reproduce
Two ways to reproduce the error:
Method 1:
1- add product 1 * 3 to the cart
2- add product 2 * 2 to the cart
3- go to the checkout
4- apply the discount and use the country for the tax to be applied
5- create order
Method 2:
1- add product 2 * 2 to the cart
2- add product 1 * 3 to the cart
3- go to the checkout
4- apply the discount and use the country for the tax to be applied
5- create order
Method 1:
1- add product 1 * 3 to the cart
2- add product 2 * 2 to the cart
3- go to the checkout
4- apply the discount and use the country for the tax to be applied
5- create order
Method 2:
1- add product 2 * 2 to the cart
2- add product 1 * 3 to the cart
3- go to the checkout
4- apply the discount and use the country for the tax to be applied
5- create order
Expected result
The function round should be applied when calculating the price_after_discount, discount_amount and taxes amount.
the actual total of the order should be 3667,52.
the actual total of the order should be 3667,52.
Actual result
Magento not doing the round function when calculating price_after_discount, discount_amount and taxes amount for the second product added to the cart.
resulting in total 3667,51 when reproducing the error using method 1 and 3667,5 when reproducing the error using method 2.
resulting in total 3667,51 when reproducing the error using method 1 and 3667,5 when reproducing the error using method 2.
Taken from the upstream issue.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: fails before, passes afterunit: fails before, passes after · integration: fails before, passes after |
| 2.4.8 | 2.4.8 clean 2.4.8-p1 clean 2.4.8-p2 clean 2.4.8-p3 clean 2.4.8-p4 clean 2.4.8-p5 clean | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: fails before, passes afterunit: fails before, passes after · integration: fails before, passes after |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 97.5%. Probability it is security relevant: 0.7%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 96.7%, refactor 1.1%, tests_only 1.0%, feature 0.4%, dependency 0.4%, docs_only 0.3% | 92.3% |
| Area | checkout | checkout 88.1%, other 4.6%, admin 1.8% | 74.8% |
| Reported version | 2.4.6-p3 | 2.4.6-p3 65.8%, 2.4.6 2.3%, 2.4.6-p4 1.1% | 42.8% |
| Scope | 0.82 of 2 | 1 58.8%, 0 29.8%, 2 11.4% | 17.2% |
| Risk | 1.50 of 2 | 2 68.7%, 0 18.3%, 1 13.0% | 28.3% |
| Worth backporting | 1.56 of 2 | 2 63.9%, 1 28.0%, 0 8.1% | 24.0% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-39687/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-39687 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/39687 Issue: https://github.com/magento/magento2/issues/38455 Author: @YuriyYavorskiy Source commit: e1d974e7f0f48e33903d6f3375a4e99f18b7b8c9 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
