UPSTREAM FIX

magento2-39704: Varnish makes a duplicate cache for the same page with the same query

Community fix magento2-39704 merged into magento/magento2 on 2025-12-23, released in 2.4.9; applies cleanly to 6 releases from 2.4.8 to 2.4.8-p5.

Varnish makes a duplicate cache for the same page with the same query edited

Pull request title
Duplicate cache fpc for same page with same query when use varnish
Pull request
magento/magento2#39704
Issues
#39706 pr-derived
Author
@rogerdz
Merged
2025-12-23
Fixed in
2.4.9
Reported on
—
Categories
Cache
Components
magento/module-page-cache

Labels

Area
Framework
Component
PageCache
Priority
P2
Severity
—
Reported on (labels)
—

Issue

Title and steps come from the upstream issue and pull request.

Description

Same as https://github.com/magento/magento2/issues/38269 but for varnish
Inspire by: https://varnish-cache.org/docs/trunk/reference/vmod_std.html#string-querysort-string

Steps to reproduce

1. Setup magento with varnish
2. Clear cache: bin/magento cache:clean
3. Run command: curl -I --location-trusted 'https://magento2.test/gear/bags.html?activity=8&style_bags=24' | grep -i X-Magento-Cache-Debug, it will return x-magento-cache-debug: MISS => correct
4. Run command: curl -I --location-trusted 'https://magento2.test/gear/bags.html?activity=8&style_bags=24' | grep -i X-Magento-Cache-Debug, it will return x-magento-cache-debug: HIT => correct
5. Run command: curl -I --location-trusted 'https://magento2.test/gear/bags.html?style_bags=24&activity=8' | grep -i X-Magento-Cache-Debug => it return x-magento-cache-debug: MISS => wrong
6. Run command: curl -I --location-trusted 'https://magento2.test/gear/bags.html?activity=8&style_bags=24&' | grep -i X-Magento-Cache-Debug => it return x-magento-cache-debug: MISS => wrong

Taken from the upstream pull request.

Code match per tag

Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.

LineCode match per tagTests
2.4.6
2.4.6 file-missing 2.4.6-p1 file-missing 2.4.6-p2 file-missing 2.4.6-p3 file-missing 2.4.6-p4 file-missing 2.4.6-p5 file-missing 2.4.6-p6 file-missing 2.4.6-p7 file-missing 2.4.6-p8 file-missing 2.4.6-p9 file-missing 2.4.6-p10 file-missing 2.4.6-p11 file-missing 2.4.6-p12 file-missing 2.4.6-p13 file-missing 2.4.6-p14 file-missing 2.4.6-p15 file-missing
2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data
2.4.7
2.4.7 file-missing 2.4.7-p1 file-missing 2.4.7-p2 file-missing 2.4.7-p3 file-missing 2.4.7-p4 file-missing 2.4.7-p5 file-missing 2.4.7-p6 file-missing 2.4.7-p7 file-missing 2.4.7-p8 file-missing 2.4.7-p9 file-missing 2.4.7-p10 file-missing
2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data
2.4.8
2.4.8 clean 2.4.8-p1 clean 2.4.8-p2 clean 2.4.8-p3 clean 2.4.8-p4 clean 2.4.8-p5 clean
2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data
2.4.9
2.4.9 conflictcontains the fix
2.4.9: no test data

Triage

Model @cf/cloudflare/clef. Probability this is a bug fix: 96.4%. Probability it is security relevant: 0.7%.

Show the model's answers and probabilities
QuestionAnswerProbabilitiesConfidence
Change kindbugfixbugfix 94.4%, feature 2.2%, refactor 1.8%, dependency 0.6%, tests_only 0.5%, docs_only 0.5%87.1%
Areaframeworkframework 94.5%, other 1.6%, frontend 1.6%88.0%
Reported versionunspecifiedunspecified 22.6%, 2.4.6 3.1%, 2.4.7-p1 2.3%5.0%
Scope0.42 of 20 64.3%, 1 29.2%, 2 6.5%25.4%
Risk0.41 of 20 62.9%, 1 33.3%, 2 3.8%26.2%
Worth backporting1.54 of 22 63.9%, 1 25.8%, 0 10.3%22.8%

Download

For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-39704/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.

Packages (1): magento/module-page-cache
Bundle README (what the ZIP ships)
# magento2-39704

Community fix merged upstream into magento/magento2, adapted by magento.watch.
This is not a patch published by Adobe.

Pull request: https://github.com/magento/magento2/pull/39704
Issue: https://github.com/magento/magento2/issues/39706
Author: @rogerdz
Source commit: 9c61dfad6bad30b46c626501a15320c1140ca26b
Modifications: test files and documentation removed, paths rewritten relative to each Composer package.
Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code.
Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)

Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.

Sources

Łukasz Bajsarowicz
Built by

Łukasz Bajsarowicz, e-commerce architect

Magento and Adobe Commerce architecture, upgrades, performance and audits for merchants and agencies since 2015; magento.watch is the tooling I use on those projects.

Open source, maintained on weekends.