magento2-39888: Cart GraphQL query fails on a null option label after a custom option is removed
Community fix magento2-39888 merged into magento/magento2 on 2025-08-04, released in 2.4.9; applies cleanly to 33 releases from 2.4.6 to 2.4.8-p5.
Cart GraphQL query fails on a null option label after a custom option is removed edited
- Pull request title
- magento/magento2#39729: Cannot return null for non-nullable field "SelectedCustomizableOption.label"
- Pull request
- magento/magento2#39888
- Issues
- —
- Author
- @KrasnoshchokBohdan
- Merged
- 2025-08-04
- Fixed in
- 2.4.9
- Reported on
- —
- Categories
- —
- Components
- magento/module-quote-graph-ql
Labels
- Area
- —
- Component
- —
- Priority
- —
- Severity
- —
- Reported on (labels)
- —
Issue
Title and steps come from the upstream issue and pull request.
Description
\Magento\QuoteGraphQl\Model\Resolver\CustomizableOptions::resolve
Steps to reproduce
2. add to cart products A and B
3. remove custom options from product A or B
4. attempt to get the cart using graphql
cart(cart_id: "xxxx") {
items {
... on SimpleCartItem {
customizable_options {
label
values {
label
value
}
}
}
}
}
}Taken from the upstream pull request.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: fails before, passes afterunit: fails before, passes after |
| 2.4.8 | 2.4.8 clean 2.4.8-p1 clean 2.4.8-p2 clean 2.4.8-p3 clean 2.4.8-p4 clean 2.4.8-p5 clean | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: fails before, passes afterunit: fails before, passes after |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 97.0%. Probability it is security relevant: 0.6%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 96.2%, tests_only 0.9%, refactor 0.9%, cleanup 0.8%, feature 0.5%, dependency 0.3%, docs_only 0.3% | 91.3% |
| Area | graphql_api | graphql_api 90.9%, checkout 6.3%, catalog 0.9% | 80.5% |
| Reported version | 2.4.6 | 2.4.6 5.4%, unspecified 5.1%, 2.4.8 2.9% | 0.7% |
| Scope | 0.66 of 2 | 0 45.7%, 1 42.5%, 2 11.8% | 10.5% |
| Risk | 0.33 of 2 | 0 77.9%, 2 11.1%, 1 11.0% | 44.8% |
| Worth backporting | 1.68 of 2 | 2 73.8%, 1 20.8%, 0 5.4% | 38.6% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-39888/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-39888 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/39888 Author: @KrasnoshchokBohdan Source commit: 983f18fa259b6ad964ed3c1a335be9ba2e59643b Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
