UPSTREAM FIX

magento2-40003: Product save with a special price throws a strtotime TypeError in getFinalPrice

Community fix magento2-40003 merged into magento/magento2 on 2025-08-07, released in 2.4.9; applies cleanly to 33 releases from 2.4.6 to 2.4.8-p5.

Product save with a special price throws a strtotime TypeError in getFinalPrice edited

Pull request title: magento/magento2#39959 catalog_product_save_before observer throws date-related error when using REST API without store-level values (getFinalPrice() issue)
Pull request: magento/magento2#40003
Issues: —
Author: @KrasnoshchokBohdan
Merged: 2025-08-07
Fixed in: 2.4.9
Reported on: —
Categories: —
Components: magento/module-catalog

Labels

Area: —
Component: —
Priority: —
Severity: —
Reported on (labels): —

Issue

Title and steps come from the upstream issue and pull request.

Description

I focused on investigation error

TypeError: strtotime(): Argument #1 ($datetime) must be of type string, DateTime given in lib/internal/Magento/Framework/Stdlib/DateTime/Timezone.php:275

the reason for it must be
\Magento\Catalog\Observer\SetSpecialPriceStartDate::execute
<img width="1132" alt="image" src="https://github.com/user-attachments/assets/7c0d35f0-c658-4c02-b4ab-3e7e41f31ee2" />

Steps to reproduce

1. Create a custom module with an observer for catalog_product_save_before.
2. Inside the observer, call $product->getFinalPrice().
3. Save product from storeview scope from admin panel (check the video from issue description)
4. Save a product using REST API: POST /rest/default/V1/products
5. Use the following JSON payload (no store-level pricing):
<details>
<summary>payload</summary>

{
  "product": {
    "sku": "testing-special-date",
    "price": 120,
    "status": 0,
    "visibility": 4,
    "type_id": "simple",
    "extension_attributes": {
      "stock_item": {
        "stock_id": 1,
        "qty": 207,
        "is_in_stock": true
      }
    },
    "custom_attributes": [
      {
        "attribute_code": "tax_class_id",
        "value": "2"
      },
      {
        "attribute_code": "special_price",
        "value": "100.00"
      }
    ]
  },
  "saveOptions": true
}

</details>

Taken from the upstream pull request.

Code match per tag

Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.

Line	Code match per tag	Tests
2.4.6	2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean	2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data
2.4.7	2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean	2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: fails before (after: error)unit: fails before, passes after · integration: could not run before, could not run after
2.4.8	2.4.8 clean 2.4.8-p1 clean 2.4.8-p2 clean 2.4.8-p3 clean 2.4.8-p4 clean 2.4.8-p5 clean	2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: fails before, passes afterunit: fails before, passes after · integration: passes before and after
2.4.9	2.4.9 conflictcontains the fix	2.4.9: no test data

Triage

Model @cf/cloudflare/clef. Probability this is a bug fix: 97.3%. Probability it is security relevant: 0.9%.

Show the model's answers and probabilities

Question	Answer	Probabilities	Confidence
Change kind	bugfix	bugfix 95.8%, refactor 1.2%, cleanup 1.0%, tests_only 0.9%, feature 0.5%, docs_only 0.3%, dependency 0.3%	90.4%
Area	catalog	catalog 76.6%, graphql_api 6.8%, admin 6.6%	54.1%
Reported version	2.4.6	2.4.6 5.3%, unspecified 4.7%, 2.4.7 4.5%	1.0%
Scope	0.82 of 2	1 46.3%, 0 35.8%, 2 17.9%	6.2%
Risk	0.67 of 2	0 59.9%, 2 27.0%, 1 13.2%	17.3%
Worth backporting	1.67 of 2	2 73.0%, 1 21.2%, 0 5.8%	37.2%

Download

For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-40003/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.

Bundle README (what the ZIP ships)

# magento2-40003

Community fix merged upstream into magento/magento2, adapted by magento.watch.
This is not a patch published by Adobe.

Pull request: https://github.com/magento/magento2/pull/40003
Author: @KrasnoshchokBohdan
Source commit: a19223c64858ffb78e37551b431cfe89f2e96ba2
Modifications: test files and documentation removed, paths rewritten relative to each Composer package.
Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code.
Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)

Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.