UPSTREAM FIX

magento2-25859: Drops the indexer changelog table when an index switches to update on save

Community fix magento2-25859 merged into magento/magento2 on 2024-05-16, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.

Drops the indexer changelog table when an index switches to update on save edited

Pull request title
[Investigation] Indexers stuck after redeploy
Pull request
magento/magento2#25859
Issues
#729 human, #29789 human
Author
@fredden
Merged
2024-05-16
Fixed in
2.4.8
Reported on
2.4.0
Categories
—
Components
magento/framework, magento/module-indexer

Labels

Area
Admin UI
Component
Indexer, Mview
Priority
P3
Severity
S3
Reported on (labels)
2.4.0

Issue

Title and steps come from the upstream issue and pull request.

Description

1. Some indexers can be stuck

Steps to reproduce

1. Try to redeploy when some indexer works

Expected result

1. Indexers can be run

Actual result

1. Some indexers can be stuck

Internal ticket: MCLOUD-5992

Taken from the upstream issue.

Code match per tag

Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.

LineCode match per tagTests
2.4.6
2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean
2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data
2.4.7
2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean
2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: fails before, passes afterunit: fails before, passes after
2.4.8
2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix
2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data
2.4.9
2.4.9 conflictcontains the fix
2.4.9: no test data

Triage

Model @cf/cloudflare/clef. Probability this is a bug fix: 90.4%. Probability it is security relevant: 0.5%.

Show the model's answers and probabilities
QuestionAnswerProbabilitiesConfidence
Change kindbugfixbugfix 92.9%, refactor 3.0%, feature 2.1%, tests_only 0.9%, dependency 0.6%, docs_only 0.4%83.8%
Areaframeworkframework 68.5%, admin 12.4%, other 10.8%42.7%
Reported versionunspecifiedunspecified 23.1%, 2.4.0 11.9%, 2.4.0-p1 1.8%6.2%
Scope0.97 of 21 47.8%, 0 27.8%, 2 24.4%4.8%
Risk1.57 of 22 67.9%, 1 20.8%, 0 11.3%27.5%
Worth backporting1.30 of 22 44.6%, 1 40.4%, 0 15.0%7.7%

Download

For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-25859/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.

Packages (2): magento/module-indexer, magento/framework
Bundle README (what the ZIP ships)
# magento2-25859

Community fix merged upstream into magento/magento2, adapted by magento.watch.
This is not a patch published by Adobe.

Pull request: https://github.com/magento/magento2/pull/25859
Issue: https://github.com/magento/magento2/issues/729
Issue: https://github.com/magento/magento2/issues/29789
Author: @fredden
Source commit: 28de31a6dbc839138103d40eff6403ae4aad5970
Modifications: test files and documentation removed, paths rewritten relative to each Composer package.
Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code.
Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)

Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.

Sources

Łukasz Bajsarowicz
Built by

Łukasz Bajsarowicz, e-commerce architect

Magento and Adobe Commerce architecture, upgrades, performance and audits for merchants and agencies since 2015; magento.watch is the tooling I use on those projects.

Open source, maintained on weekends.