magento2-30070: Custom attributes missing on the current account navigation link
Community fix magento2-30070 merged into magento/magento2 on 2024-10-18, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.
Fixes custom attributes missing on the current account navigation link edited
- Pull request title
- Pass custom attributes to current link via XML
- Pull request
- magento/magento2#30070
- Issues
- #38500 pr-derived
- Author
- @mattkrupnik
- Merged
- 2024-10-18
- Fixed in
- 2.4.8
- Reported on
- —
- Categories
- —
- Components
- magento/framework
Labels
- Area
- Framework
- Component
- View
- Priority
- P3
- Severity
- S3
- Reported on (labels)
- 2.4.x
Issue
Title and steps come from the upstream issue and pull request.
Description
<referenceBlock name="customer-account-navigation-account-link">
<arguments>
<argument name="attributes" xsi:type="array">
<item name="class" xsi:type="string">account-custom-class</item>
</argument>
</arguments>
</referenceBlock>
But when customer-account-navigation-account-link is as current page in this case it is https://sample.com/customer/account/ our custom attribute dosn't show because method getAttributesHtml() [isn't used for current link](https://github.com/magento/magento2/pull/30070/commits/526b9d7e3a070870047acb37aaaf7ccff93540d1).Taken from the upstream pull request.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 85.7%. Probability it is security relevant: 0.5%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 94.2%, feature 3.4%, refactor 1.5%, tests_only 0.4%, dependency 0.3%, docs_only 0.3% | 86.7% |
| Area | framework | framework 69.5%, customer 16.0%, frontend 10.5% | 45.1% |
| Reported version | unspecified | unspecified 31.0%, 2.4.6 2.5%, 2.4.6-p1 1.7% | 9.2% |
| Scope | 0.43 of 2 | 0 62.9%, 1 31.4%, 2 5.8% | 24.6% |
| Risk | 0.33 of 2 | 0 68.9%, 1 29.2%, 2 1.9% | 34.0% |
| Worth backporting | 1.26 of 2 | 2 50.2%, 1 25.9%, 0 23.9% | 6.4% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-30070/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-30070 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/30070 Issue: https://github.com/magento/magento2/issues/38500 Author: @mattkrupnik Source commit: 3debd1a3485f8eb783e8b9ce035ee196e7665301 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
