UPSTREAM FIX

magento2-32359: Login as customer opt-in checkbox not translatable

Community fix magento2-32359 merged into magento/magento2 on 2024-12-24, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.

Pull request title
Login as customer opt-in checkbox not translatable
Pull request
magento/magento2#32359
Issues
#32329 human
Author
@ejaz-alam
Merged
2024-12-24
Fixed in
2.4.8
Reported on
2.4.2
Categories
Admin, Customer
Components
magento/module-login-as-customer-assistance

Labels

Area
Account
Component
LoginAsCustomer
Priority
P3
Severity
S3
Reported on (labels)
2.4.2

Issue

Title and steps come from the upstream issue and pull request.

Description

1. Fields "Title for Login as Customer opt-in checkbox" and "Login as Customer checkbox tooltip" are for scope "Website" So you can't translate for storeview
![image](https://user-images.githubusercontent.com/20226525/109659299-d4626c00-7b67-11eb-8e67-261a0e7d0564.png)

Steps to reproduce

1. In back office > Stores > Configuration >Customers > Login as Customer
2. Look at the scope for fields "Title for Login as Customer opt-in checkbox" and "Login as Customer checkbox tooltip"

Expected result

1. Fields "Title for Login as Customer opt-in checkbox" and "Login as Customer checkbox tooltip" must be for scope "Store view" So you can translate for storeview

Actual result

1. Fields "Title for Login as Customer opt-in checkbox" and "Login as Customer checkbox tooltip" are for scope "Website" So you can't translate for storeview
![image](https://user-images.githubusercontent.com/20226525/109659299-d4626c00-7b67-11eb-8e67-261a0e7d0564.png)


---
Please provide [Severity](https://devdocs.magento.com/guides/v2.4/contributor-guide/contributing.html#backlog) assessment for the Issue as Reporter. This information will help during Confirmation and Issue triage processes.

- [ ] Severity: S0 _- Affects critical data or functionality and leaves users without workaround._
- [ ] Severity: S1 _- Affects critical data or functionality and forces users to employ a workaround._
- [ ] Severity: S2 _- Affects non-critical data or functionality and forces users to employ a workaround._
- [ ] Severity: S3 _- Affects non-critical data or functionality and does not force users to employ a workaround._
- [x] Severity: S4 _- Affects aesthetics, professional look and feel, “quality” or “usability”._

Taken from the upstream issue.

Code match per tag

Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.

LineCode match per tagTests
2.4.6
2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean
2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data
2.4.7
2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean
2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data
2.4.8
2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix
2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data
2.4.9
2.4.9 conflictcontains the fix
2.4.9: no test data

Triage

Model @cf/cloudflare/clef. Probability this is a bug fix: 97.2%. Probability it is security relevant: 6.8%.

Show the model's answers and probabilities
QuestionAnswerProbabilitiesConfidence
Change kindbugfixbugfix 95.0%, refactor 2.2%, feature 1.5%, docs_only 0.5%, tests_only 0.5%, dependency 0.4%88.3%
Areacustomercustomer 47.2%, admin 42.4%, other 3.8%32.0%
Reported version2.4.22.4.2 63.6%, 2.4.2-p2 6.4%, 2.4.2-p1 3.9%40.4%
Scope0.42 of 20 64.2%, 1 29.1%, 2 6.7%25.2%
Risk0.25 of 20 81.0%, 1 13.1%, 2 6.0%51.4%
Worth backporting1.11 of 22 42.9%, 0 32.1%, 1 25.0%2.4%

Download

For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-32359/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.

Packages (1): magento/module-login-as-customer-assistance
Bundle README (what the ZIP ships)
# magento2-32359

Community fix merged upstream into magento/magento2, adapted by magento.watch.
This is not a patch published by Adobe.

Pull request: https://github.com/magento/magento2/pull/32359
Issue: https://github.com/magento/magento2/issues/32329
Author: @ejaz-alam
Source commit: 54bbdfefd96035c880afcfb678afd79019d3245b
Modifications: test files and documentation removed, paths rewritten relative to each Composer package.
Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code.
Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)

Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.

Sources

Łukasz Bajsarowicz
Built by

Łukasz Bajsarowicz, e-commerce architect

Magento and Adobe Commerce architecture, upgrades, performance and audits for merchants and agencies since 2015; magento.watch is the tooling I use on those projects.

Open source, maintained on weekends.