UPSTREAM FIX

magento2-32919: Removes double spaces between attributes in link and script tags

Community fix magento2-32919 merged into magento/magento2 on 2024-05-28, released in 2.4.8; applies cleanly to 27 releases from 2.4.6 to 2.4.7-p10.

Removes double spaces between attributes in link and script tags edited

Pull request title: [View] Removed extra space in link and script tag
Pull request: magento/magento2#32919
Issues: #32920 pr-derived
Author: @srsathish92
Merged: 2024-05-28
Fixed in: 2.4.8
Reported on: —
Categories: —
Components: magento/framework

Labels

Area: Framework
Component: Backend, View
Priority: P4
Severity: S4
Reported on (labels): 2.4.x

Issue

Title and steps come from the upstream issue and pull request.

Description

This PR helps to change extra spaces into single space in <link> and <script> tag.

Steps to reproduce

./vendor/bin/phpunit -c dev/tests/unit/phpunit.xml.dist lib/internal/Magento/Framework/View/Test/Unit/Page/Config/RendererTest.php

2. Open the store and see <link> and <script> tag using view source code.
3. <link> and <script> should be without double spaces between attributes.

Actual Result:
![w_extraspace](https://user-images.githubusercontent.com/18184256/116742365-e13ef700-aa14-11eb-8c62-2df3548fa4fc.png)

Excepted Result:
![wo_extraspace](https://user-images.githubusercontent.com/18184256/116742657-485cab80-aa15-11eb-8396-005a36c80236.png)

Taken from the upstream pull request.

Code match per tag

Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.

Line	Code match per tag	Tests
2.4.6	2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean	2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data
2.4.7	2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean	2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: fails before, passes afterunit: fails before, passes after
2.4.8	2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix	2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data
2.4.9	2.4.9 conflictcontains the fix	2.4.9: no test data

Triage

Model @cf/cloudflare/clef. Probability this is a bug fix: 64.2%. Probability it is security relevant: 0.8%.

Show the model's answers and probabilities

Question	Answer	Probabilities	Confidence
Change kind	bugfix	bugfix 88.0%, refactor 8.3%, tests_only 1.7%, feature 1.0%, docs_only 0.5%, dependency 0.5%	73.8%
Area	framework	framework 61.7%, frontend 31.7%, admin 2.2%	40.8%
Reported version	unspecified	unspecified 24.8%, 2.4.3-p1 4.9%, 2.4.4-p1 3.8%	6.2%
Scope	0.58 of 2	1 47.7%, 0 47.2%, 2 5.0%	18.0%
Risk	0.27 of 2	0 74.1%, 1 24.4%, 2 1.5%	41.3%
Worth backporting	0.30 of 2	0 77.6%, 1 15.1%, 2 7.3%	44.6%

Download

For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-32919/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.

Bundle README (what the ZIP ships)

# magento2-32919

Community fix merged upstream into magento/magento2, adapted by magento.watch.
This is not a patch published by Adobe.

Pull request: https://github.com/magento/magento2/pull/32919
Issue: https://github.com/magento/magento2/issues/32920
Author: @srsathish92
Source commit: c03b74a07afe7748243c071dc812279fbda21044
Modifications: test files and documentation removed, paths rewritten relative to each Composer package.
Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code.
Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)

Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.