UPSTREAM FIX

magento2-32922: Excludes styles of disabled modules from compiled CSS when configured

Community fix magento2-32922 merged into magento/magento2 on 2024-07-14, released in 2.4.8; applies cleanly to 11 releases from 2.4.7 to 2.4.7-p10.

Excludes styles of disabled modules from compiled CSS when configured edited

Pull request title: Static content is deploying for disabled modules
Pull request: magento/magento2#32922
Issues: #24666 human
Author: @mrtuvn
Merged: 2024-07-14
Fixed in: 2.4.8
Reported on: —
Categories: —
Components: magento/framework

Labels

Area: UI Framework
Component: CSS, Deploy
Priority: P2
Severity: S2
Reported on (labels): —

Issue

Title and steps come from the upstream issue and pull request.

Description

- Finding references to the selector .payment-method-braintree

Steps to reproduce

1. Setup vanilla 2.3-develop installation
2. Take a look at the file app/design/frontend/Magento/blank/Magento_Braintree/web/css/source/_module.less, notice the selector .payment-method-braintree is in there and also notice this selector is in no other file in the Magento source code except for this file in the Magento_Braintree module in the
Magento/Blank theme.
3. Now disable that module (and its dependency): bin/magento module:disable Magento_Braintree Magento_BraintreeGraphQl
4. Remove potential left over files: rm -R var/view_preprocessed/* pub/static/*
5. Run static content deploy: bin/magento setup:static-content:deploy -f --theme Magento/blank en_US
6. Look at the generated file pub/static/frontend/Magento/blank/en_US/css/styles-m.css

Expected result

- Not finding a reference to the selector .payment-method-braintree

Actual result

- Finding references to the selector .payment-method-braintree

*Update*: In hindsight, @shkodasv is talking about the deprecated "disabling module output" feature of Magento which was removed in Magento 2.2 I believe. But the issue is still valid for disabled modules as well, or should we open a new issue then?

Taken from the upstream issue.

Code match per tag

Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.

Line	Code match per tag	Tests
2.4.6	2.4.6 conflict 2.4.6-p1 conflict 2.4.6-p2 conflict 2.4.6-p3 conflict 2.4.6-p4 conflict 2.4.6-p5 conflict 2.4.6-p6 conflict 2.4.6-p7 conflict 2.4.6-p8 conflict 2.4.6-p9 conflict 2.4.6-p10 conflict 2.4.6-p11 conflict 2.4.6-p12 conflict 2.4.6-p13 conflict 2.4.6-p14 conflict 2.4.6-p15 conflict	2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data
2.4.7	2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean	2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: fails before, passes afterunit: fails before, passes after
2.4.8	2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix	2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data
2.4.9	2.4.9 conflictcontains the fix	2.4.9: no test data

Triage

Model @cf/cloudflare/clef. Probability this is a bug fix: 78.8%. Probability it is security relevant: 0.7%.

Show the model's answers and probabilities

Question	Answer	Probabilities	Confidence
Change kind	bugfix	bugfix 76.0%, feature 19.7%, refactor 2.4%, tests_only 1.0%, dependency 0.5%, docs_only 0.4%	54.1%
Area	frontend	frontend 77.0%, framework 19.6%, other 1.0%	57.9%
Reported version	unspecified	unspecified 41.1%, 2.4.8-p3 1.4%, 2.4.3-p1 1.4%	16.4%
Scope	1.00 of 2	1 35.2%, 0 32.6%, 2 32.2%	0.1%
Risk	0.65 of 2	1 56.6%, 0 39.2%, 2 4.3%	21.3%
Worth backporting	1.08 of 2	2 37.6%, 1 32.5%, 0 29.9%	0.5%

Download

For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-32922/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.

Bundle README (what the ZIP ships)

# magento2-32922

Community fix merged upstream into magento/magento2, adapted by magento.watch.
This is not a patch published by Adobe.

Pull request: https://github.com/magento/magento2/pull/32922
Issue: https://github.com/magento/magento2/issues/24666
Author: @mrtuvn
Source commit: 60b953dce93d7c02961fbb2fe84c4878eb3b25ae
Modifications: test files and documentation removed, paths rewritten relative to each Composer package.
Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code.
Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)

Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.