magento2-33120: Updates the getItemsByColumnValue $value annotation to primitive types
Community fix magento2-33120 merged into magento/magento2 on 2025-06-18, released in 2.4.9; applies cleanly to 33 releases from 2.4.6 to 2.4.8-p5.
Updates the getItemsByColumnValue $value annotation to primitive types edited
- Pull request title
- getItemsByColumnValue wrong type declaration
- Pull request
- magento/magento2#33120
- Issues
- #33070 human
- Author
- @yogesh-valiya
- Merged
- 2025-06-18
- Fixed in
- 2.4.9
- Reported on
- —
- Categories
- —
- Components
- magento/framework
Labels
- Area
- Framework
- Component
- Framework/Data
- Priority
- P3
- Severity
- —
- Reported on (labels)
- —
Issue
Title and steps come from the upstream issue and pull request.
Description
null.Steps to reproduce
getItemsByColumnValue([string], [array]) on any collection.Expected result
Actual result
null.Component: magento-framework
File: vendor/magento/framework/Data/Collection.php
Taken from the upstream issue.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 clean 2.4.6-p12 clean 2.4.6-p13 clean 2.4.6-p14 clean 2.4.6-p15 clean | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 clean 2.4.7-p7 clean 2.4.7-p8 clean 2.4.7-p9 clean 2.4.7-p10 clean | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 clean 2.4.8-p1 clean 2.4.8-p2 clean 2.4.8-p3 clean 2.4.8-p4 clean 2.4.8-p5 clean | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 82.0%. Probability it is security relevant: 0.4%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | docs_only | docs_only 54.3%, bugfix 40.4%, refactor 2.8%, cleanup 1.2%, tests_only 0.6%, feature 0.4%, dependency 0.3% | 37.0% |
| Area | framework | framework 92.4%, admin 1.9%, catalog 1.2% | 83.5% |
| Reported version | 2.4.2 | 2.4.2 60.8%, 2.4.2-p2 5.8%, 2.4.2-p1 4.5% | 36.9% |
| Scope | 0.27 of 2 | 0 76.3%, 1 20.3%, 2 3.5% | 43.6% |
| Risk | 0.27 of 2 | 0 76.5%, 1 19.7%, 2 3.9% | 43.7% |
| Worth backporting | 0.89 of 2 | 0 41.4%, 2 30.5%, 1 28.2% | 1.5% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-33120/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-33120 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/33120 Issue: https://github.com/magento/magento2/issues/33070 Author: @yogesh-valiya Source commit: a6b5203012f741f4304540bf9de4a58a17eeae4c Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
