magento2-35174: Sets utf8mb4 as default table charset for the 10.6 and mysql_8_29 keys
Community fix magento2-35174 merged into magento/magento2 on 2024-10-31, released in 2.4.8; applies cleanly to 17 releases from 2.4.6 to 2.4.7-p5.
Sets utf8mb4 as default table charset for the 10.6 and mysql_8_29 keys edited
- Pull request title
- Set default collation to utf8mb4
- Pull request
- magento/magento2#35174
- Issues
- #38085 pr-derived
- Author
- @sippsolutions
- Merged
- 2024-10-31
- Fixed in
- 2.4.8
- Reported on
- —
- Categories
- —
- Components
- magento/framework
Labels
- Area
- Framework
- Component
- Setup
- Priority
- P3
- Severity
- —
- Reported on (labels)
- 2.4.x
Issue
Title and steps come from the upstream issue and pull request.
Description
https://dev.mysql.com/doc/relnotes/mysql/8.0/en/news-8-0-24.html
https://dev.mysql.com/doc/refman/8.0/en/charset-unicode-utf8mb3.html
We should therefor ensure utf8mb4 is used.
Taken from the upstream pull request.
Code match per tag
Each tag was checked with git apply --check against that tag's files. A clean match means the change applies; it is not a test result. Tags that already contain the fix are marked.
| Line | Code match per tag | Tests |
|---|---|---|
| 2.4.6 | 2.4.6 clean 2.4.6-p1 clean 2.4.6-p2 clean 2.4.6-p3 clean 2.4.6-p4 clean 2.4.6-p5 clean 2.4.6-p6 clean 2.4.6-p7 clean 2.4.6-p8 clean 2.4.6-p9 clean 2.4.6-p10 clean 2.4.6-p11 conflict 2.4.6-p12 conflict 2.4.6-p13 conflict 2.4.6-p14 conflict 2.4.6-p15 conflict | 2.4.6: no test data 2.4.6-p1: no test data 2.4.6-p2: no test data 2.4.6-p3: no test data 2.4.6-p4: no test data 2.4.6-p5: no test data 2.4.6-p6: no test data 2.4.6-p7: no test data 2.4.6-p8: no test data 2.4.6-p9: no test data 2.4.6-p10: no test data 2.4.6-p11: no test data 2.4.6-p12: no test data 2.4.6-p13: no test data 2.4.6-p14: no test data 2.4.6-p15: no test data |
| 2.4.7 | 2.4.7 clean 2.4.7-p1 clean 2.4.7-p2 clean 2.4.7-p3 clean 2.4.7-p4 clean 2.4.7-p5 clean 2.4.7-p6 conflict 2.4.7-p7 conflict 2.4.7-p8 conflict 2.4.7-p9 conflict 2.4.7-p10 conflict | 2.4.7: no test data 2.4.7-p1: no test data 2.4.7-p2: no test data 2.4.7-p3: no test data 2.4.7-p4: no test data 2.4.7-p5: no test data 2.4.7-p6: no test data 2.4.7-p7: no test data 2.4.7-p8: no test data 2.4.7-p9: no test data 2.4.7-p10: no test data |
| 2.4.8 | 2.4.8 conflictcontains the fix 2.4.8-p1 conflictcontains the fix 2.4.8-p2 conflictcontains the fix 2.4.8-p3 conflictcontains the fix 2.4.8-p4 conflictcontains the fix 2.4.8-p5 conflictcontains the fix | 2.4.8: no test data 2.4.8-p1: no test data 2.4.8-p2: no test data 2.4.8-p3: no test data 2.4.8-p4: no test data 2.4.8-p5: no test data |
| 2.4.9 | 2.4.9 conflictcontains the fix | 2.4.9: no test data |
Triage
Model @cf/cloudflare/clef. Probability this is a bug fix: 57.6%. Probability it is security relevant: 0.9%.
Show the model's answers and probabilities
| Question | Answer | Probabilities | Confidence |
|---|---|---|---|
| Change kind | bugfix | bugfix 70.9%, refactor 12.6%, tests_only 9.4%, feature 4.1%, dependency 2.4%, docs_only 0.6% | 43.5% |
| Area | framework | framework 90.9%, other 3.7%, admin 1.6% | 80.3% |
| Reported version | unspecified | unspecified 26.8%, 2.4.6 3.2%, 2.4.4 2.0% | 6.9% |
| Scope | 0.73 of 2 | 1 46.2%, 0 40.2%, 2 13.6% | 9.0% |
| Risk | 0.89 of 2 | 0 43.9%, 2 32.8%, 1 23.3% | 3.2% |
| Worth backporting | 1.21 of 2 | 2 42.9%, 1 35.6%, 0 21.5% | 3.6% |
Download
For cweagans/composer-patches, choose a version below and download the bundle. Copy its magento2-35174/ folder into patches/composer/, merge composer.patches.json into composer.json, then run composer install. Test files are always removed; paths are relative to each package root, using the default -p1 level.
Bundle README (what the ZIP ships)
# magento2-35174 Community fix merged upstream into magento/magento2, adapted by magento.watch. This is not a patch published by Adobe. Pull request: https://github.com/magento/magento2/pull/35174 Issue: https://github.com/magento/magento2/issues/38085 Author: @sippsolutions Source commit: 1389b85828810dec3fa92bff55df18b816e38191 Modifications: test files and documentation removed, paths rewritten relative to each Composer package. Licence: OSL-3.0 / AFL-3.0, as the original Magento Open Source code. Maintainer: Łukasz Bajsarowicz (@lbajsarowicz)
Licence: Magento Open Source code under OSL-3.0 and AFL-3.0. The bundle carries the original author, source commit and the list of modifications.
